Alex-Tideman

Mod4 Syllabus

General Expectations

It's a been a quite a journey so far for you all at Turing. Don't let all those months of hard work fizzle out. Let's look at how to finish the program strong and begin your professional career off on the right foot.

• Be respectful. Be nice. Work hard.
• Come to every class. Pay attention, ask questions, be involved in your education.
• If you cannot make a class, please communicate with Alex and Meeka.
• If it's a remote day, get life stuff done.

Alex-Tideman

const denver = {
   elevation: 5280,
   mayor: "Michael Hancock",
   neighborhoods: [
     "LoDo",
     "Five Points",
     "Cap Hill",
     "East Colfax",
     "RiNo",

Alex-Tideman

The Focus

The goal for the next hour is to practice your technical code review skills and providing critical feedback. On the job, code reviews are huge part of being on a team and being able to accept and implement feedback is a vital skill.

Feedback should be positive, actionable and clear enough that anyone reading the issue could implement without any clarifications.

Areas of Review

1. Code Patterns - Identify coding patterns or practices that are detrimental to the code base or go against the majority of the code base (consistency). Are there too many global variables? Are you using .forEach instead of .map to create new arrays? Lots of if/else statements? Functions are too big?
2. Style - Is your code consistently styled (spacing, naming conventions, file names)? Are you using a linter? Are you switching between ES5 and ES6?
3. Communication - Are you writting concise commit messages? Are you using branches for small, complete pieces of functionality and have PR's with comments?