Skip to content

Instantly share code, notes, and snippets.

@AquaGeek
AquaGeek / 0001-activerecord-test-cases-fi.patch
Created May 14, 2011 02:36
Rails Lighthouse ticket #6746
From 0c006d3a02a07cb0531727d247c6a85e4cff821b Mon Sep 17 00:00:00 2001
From: Joe Van Dyk <joe@fixieconsulting.com>
Date: Mon, 25 Apr 2011 21:15:35 -0700
Subject: [PATCH] activerecord/test/cases/finder_test.rb missing a require statement
Test wouldn't run by itself.
---
activerecord/test/cases/finder_test.rb | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
@AquaGeek
AquaGeek / error_messages.diff
Created May 14, 2011 02:36
Rails Lighthouse ticket #6745
From 318b7c7bad051fd6fdb72f24f4180a1b87b27844 Mon Sep 17 00:00:00 2001
From: Josh Sharpe <josh.m.sharpe@gmail.com>
Date: Mon, 25 Apr 2011 23:17:13 -0400
Subject: [PATCH] ActiveModel::Errors#full_messages shouldn't generate an error message w/ an associations class name in it
---
activemodel/lib/active_model/errors.rb | 2 +-
.../test/cases/autosave_association_test.rb | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
@AquaGeek
AquaGeek / active_model_xml_fix.diff
Created May 14, 2011 02:36
Rails Lighthouse ticket #6744
From 04fb78f610d17726857b39157a2f0dc56b39e800 Mon Sep 17 00:00:00 2001
From: Jim Herzberg <jimmiesh@gmail.com>
Date: Mon, 25 Apr 2011 17:55:56 -0700
Subject: [PATCH] Attributes with :string type should not be given the type passed in model serialization options.
---
activemodel/lib/active_model/serializers/xml.rb | 2 +-
.../cases/serializers/xml_serialization_test.rb | 5 +++++
2 files changed, 6 insertions(+), 1 deletions(-)
@AquaGeek
AquaGeek / optional_password.diff
Created May 14, 2011 02:36
Rails Lighthouse ticket #6742
From 5e9f5b021c1bf04a51ae61843fc407d64fe18dfc Mon Sep 17 00:00:00 2001
From: Matthew Daubert <mdaubert@gmail.com>
Date: Mon, 25 Apr 2011 08:59:37 -0400
Subject: [PATCH 1/2] Added support for required configuration parameter
---
activemodel/lib/active_model/secure_password.rb | 19 ++++++++++++++-----
activemodel/test/cases/secure_password_test.rb | 13 +++++++++++++
activemodel/test/models/user.rb | 2 +-
3 files changed, 28 insertions(+), 6 deletions(-)
@AquaGeek
AquaGeek / patch.diff
Created May 14, 2011 02:35
Rails Lighthouse ticket #6741
From 86ea94e4d0c228c79b3709f0c667ba90b02e41cd Mon Sep 17 00:00:00 2001
From: Nick Howard <ndh@baroquebobcat.com>
Date: Sun, 1 May 2011 16:22:46 -0600
Subject: [PATCH] Fix for lighthouse #6741
- adds tests for find_or_create_by and find_or_initialize_by on has_many associations
- changes the behavior of ActiveRecord::Associations::CollectionProxy#method_missing to differ to
ActiveRecord::FinderMethods#find_or_instantiator_by_attributes for arg processing and saving so
find_or_create_by's api on associations will be consistent w/ the api for model classes.
---
@AquaGeek
AquaGeek / proper_reset_inflector_scopes.diff
Created May 14, 2011 02:35
Rails Lighthouse ticket #6740
From ba9891f13da80bf5991c50ce53ab9db3fe852600 Mon Sep 17 00:00:00 2001
From: Stefan Huber <msnexploder@gmail.com>
Date: Mon, 25 Apr 2011 02:17:22 +0100
Subject: [PATCH] proper reset all inflector scopes
---
.../lib/active_support/inflector/inflections.rb | 2 +-
activesupport/test/inflector_test.rb | 42 ++++++++++++++------
2 files changed, 31 insertions(+), 13 deletions(-)
@AquaGeek
AquaGeek / patch.diff
Created May 14, 2011 02:35
Rails Lighthouse ticket #6738
From fe2fd8e361205dca71bb843aa91bbd84bd397072 Mon Sep 17 00:00:00 2001
From: Sebastian Martinez <sebastian@wyeworks.com>
Date: Fri, 22 Apr 2011 21:57:52 -0300
Subject: [PATCH] Remove useless argument
---
.../abstract/connection_pool.rb | 2 +-
.../abstract/schema_statements.rb | 2 +-
.../connection_adapters/mysql2_adapter.rb | 2 +-
.../connection_adapters/mysql_adapter.rb | 2 +-
@AquaGeek
AquaGeek / patch.diff
Created May 14, 2011 02:35
Rails Lighthouse ticket #6734
875c875
< asset_file_path!(path_to_stylesheet(source))
---
> asset_file_path!(compute_public_path(source, 'stylesheets', 'css', false))
882c882
< asset_file_path!(path_to_javascript(source))
---
> asset_file_path!(compute_public_path(source, 'javascripts', 'js', false))
@AquaGeek
AquaGeek / speedup_association_preload.diff
Created May 14, 2011 02:35
Rails Lighthouse ticket #6726
From e5fafbf5220e7346ce718ffed1c6f1135269f7e8 Mon Sep 17 00:00:00 2001
From: Kir Maximov <kir@maxkir.com>
Date: Tue, 19 Apr 2011 23:00:18 +0200
Subject: [PATCH] Speedup associations preloading for case of many records + many :include options
---
.../lib/active_record/association_preload.rb | 10 +++++++---
1 files changed, 7 insertions(+), 3 deletions(-)
diff --git a/activerecord/lib/active_record/association_preload.rb b/activerecord/lib/active_record/association_preload.rb
@AquaGeek
AquaGeek / active_resource_class_loading.diff
Created May 14, 2011 02:35
Rails Lighthouse ticket #6716
From 03b6333fc14433803d58f844e93b0e37a6f722a4 Mon Sep 17 00:00:00 2001
From: Brian Durand <brian@embellishedvisions.com>
Date: Mon, 18 Apr 2011 14:34:03 -0500
Subject: [PATCH] Fix loading of classes from within ActiveResource to always look in the current namespace. [#6716 state:resolved]
---
activeresource/lib/active_resource/base.rb | 2 +-
activeresource/test/cases/base_test.rb | 6 ++++++
activeresource/test/fixtures/sound.rb | 8 ++++++++
3 files changed, 15 insertions(+), 1 deletions(-)