BenjaminPoulain

diff --git a/Callgrind Viewer/FileLoader.m b/Callgrind Viewer/FileLoader.m
index 823e128..2a6c906 100644
--- a/Callgrind Viewer/FileLoader.m     
+++ b/Callgrind Viewer/FileLoader.m     
@@ -48,6 +48,7 @@ static inline ssize_t indexOfNextNewLineChar(const char* data, size_t offset, si
     if ([_pendingDataBuffer length] > 0) {
         ssize_t nextNewLine = indexOfNextNewLineChar(data, 0, size);
         if (nextNewLine >= 0) {
+            assert(nextNewLine <= size);
             [_pendingDataBuffer appendBytes:data length:nextNewLine];

BenjaminPoulain

From fe302fd2dbf41058eb745541d7c971716075b13b Mon Sep 17 00:00:00 2001
From: Benjamin Poulain <[email protected]>
Date: Thu, 1 Sep 2011 18:52:03 +0200
Subject: [PATCH] Add parsing for the FormatVersion and the Creator lines.

The first two lines of a callgrind files are the optional lines for
the FormatVersion and Creator.
---
 Callgrind Viewer/FileLoader.h |    6 ++++
 Callgrind Viewer/FileLoader.m |   62 +++++++++++++++++++++++++++++++++++++++-

BenjaminPoulain

From b04c392ecf5b3c097b4d2a06502193e237d681c4 Mon Sep 17 00:00:00 2001
From: Benjamin Poulain <[email protected]>
Date: Thu, 1 Sep 2011 19:32:04 +0200
Subject: [PATCH] Add basic parsing for the command header.

The "cmd:" header represent the command profiled by Valgrind.
---
 Callgrind Viewer/FileLoader.m |   21 +++++++++++++++++++++
 1 files changed, 21 insertions(+), 0 deletions(-)

BenjaminPoulain

From b23bd097bd114389754f91f89a0a22098f790fed Mon Sep 17 00:00:00 2001
From: Benjamin Poulain <[email protected]>
Date: Thu, 1 Sep 2011 21:56:43 +0200
Subject: [PATCH 2/7] Pass the information loaded by the FileLoader to the
 document and update the UI accordingly

When the file loader has finished loading the data, pass the information back to the client. Currently,
only the command name is read and passed to NSDocument. The display name is update accordingly
so that the window title show the command that was being profiled by Valgrind.
---

BenjaminPoulain

From a3ca019fd9300883d5e56beac98150cb1bcfff6e Mon Sep 17 00:00:00 2001
From: Benjamin Poulain <[email protected]>
Date: Sat, 3 Sep 2011 16:09:02 +0200
Subject: [PATCH] Matches all the statements that can be present in the
 header.

---
 Callgrind Viewer/FileLoader.m |   70 ++++++++++++++++++++++++++++++++++++++--
 1 files changed, 66 insertions(+), 4 deletions(-)

BenjaminPoulain

Index: Source/WebCore/ChangeLog
===================================================================
--- Source/WebCore/ChangeLog	(revision 107269)
+++ Source/WebCore/ChangeLog	(working copy)
@@ -1,3 +1,16 @@
+2012-02-09  Benjamin Poulain  <[email protected]>
+
+        The localization of htmlSelectMultipleItems() needs better support of pluralization
+        https://bugs.webkit.org/show_bug.cgi?id=78197
+

BenjaminPoulain

enum KeywordValue {
  NotKeyword,
  ValidKeyword,
  InvalidKeyword
}

static inline KeywordValue parseValidPrimitive(CSSPropertyID id, int value)
{
   switch(id) {
   case CSSPropertyEmptyCells:          // show | hide | inherit

BenjaminPoulain

diff --git a/Source/JavaScriptCore/runtime/ArrayPrototype.cpp b/Source/JavaScriptCore/runtime/ArrayPrototype.cpp
index 2f000fc..6692d8e 100644
--- a/Source/JavaScriptCore/runtime/ArrayPrototype.cpp
+++ b/Source/JavaScriptCore/runtime/ArrayPrototype.cpp
@@ -387,7 +387,7 @@ EncodedJSValue JSC_HOST_CALL arrayProtoFuncJoin(ExecState* exec)
 
     UString separator;
     if (!exec->argument(0).isUndefined())
-        separator = exec->argument(0).toString(exec)->value(exec);
+        separator = exec->argument(0).toUString(exec);

BenjaminPoulain

Index: Source/WebCore/ChangeLog
===================================================================
--- Source/WebCore/ChangeLog	(revision 111362)
+++ Source/WebCore/ChangeLog	(working copy)
@@ -1,3 +1,12 @@
+2012-03-19  Benjamin Poulain  <[email protected]>
+
+        Build fix for Debug build after r111358
+
+        Unreviewed.

BenjaminPoulain

Replace: "value.toString(exec)->value(exec)" by value.toUString(exec):


diff --git a/Source/JavaScriptCore/runtime/JSString.h b/Source/JavaScriptCore/runtime/JSString.h
index 32a3278..1477962 100644
--- a/Source/JavaScriptCore/runtime/JSString.h
+++ b/Source/JavaScriptCore/runtime/JSString.h
@@ -462,6 +462,20 @@ namespace JSC {
         return toStringSlowCase(exec);
     }