This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Obj-C: | |
| @interface | |
| -uid | |
| @end | |
| JSC: | |
| object.uid() | |
| to --> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| diff --git a/Source/JavaScriptCore/runtime/ArrayPrototype.cpp b/Source/JavaScriptCore/runtime/ArrayPrototype.cpp | |
| index 818895c..4b1278a 100644 | |
| --- a/Source/JavaScriptCore/runtime/ArrayPrototype.cpp | |
| +++ b/Source/JavaScriptCore/runtime/ArrayPrototype.cpp | |
| @@ -383,7 +383,7 @@ EncodedJSValue JSC_HOST_CALL arrayProtoFuncJoin(ExecState* exec) | |
| UString separator; | |
| if (!exec->argument(0).isUndefined()) | |
| - separator = exec->argument(0).toString(exec)->value(exec); | |
| + separator = fastJSValuetoUString(exec->argument(0), exec); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Replace: "value.toString(exec)->value(exec)" by value.toUString(exec): | |
| diff --git a/Source/JavaScriptCore/runtime/JSString.h b/Source/JavaScriptCore/runtime/JSString.h | |
| index 32a3278..1477962 100644 | |
| --- a/Source/JavaScriptCore/runtime/JSString.h | |
| +++ b/Source/JavaScriptCore/runtime/JSString.h | |
| @@ -462,6 +462,20 @@ namespace JSC { | |
| return toStringSlowCase(exec); | |
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Index: Source/WebCore/ChangeLog | |
| =================================================================== | |
| --- Source/WebCore/ChangeLog (revision 111362) | |
| +++ Source/WebCore/ChangeLog (working copy) | |
| @@ -1,3 +1,12 @@ | |
| +2012-03-19 Benjamin Poulain <[email protected]> | |
| + | |
| + Build fix for Debug build after r111358 | |
| + | |
| + Unreviewed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| diff --git a/Source/JavaScriptCore/runtime/ArrayPrototype.cpp b/Source/JavaScriptCore/runtime/ArrayPrototype.cpp | |
| index 2f000fc..6692d8e 100644 | |
| --- a/Source/JavaScriptCore/runtime/ArrayPrototype.cpp | |
| +++ b/Source/JavaScriptCore/runtime/ArrayPrototype.cpp | |
| @@ -387,7 +387,7 @@ EncodedJSValue JSC_HOST_CALL arrayProtoFuncJoin(ExecState* exec) | |
| UString separator; | |
| if (!exec->argument(0).isUndefined()) | |
| - separator = exec->argument(0).toString(exec)->value(exec); | |
| + separator = exec->argument(0).toUString(exec); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| enum KeywordValue { | |
| NotKeyword, | |
| ValidKeyword, | |
| InvalidKeyword | |
| } | |
| static inline KeywordValue parseValidPrimitive(CSSPropertyID id, int value) | |
| { | |
| switch(id) { | |
| case CSSPropertyEmptyCells: // show | hide | inherit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Index: Source/WebCore/ChangeLog | |
| =================================================================== | |
| --- Source/WebCore/ChangeLog (revision 107269) | |
| +++ Source/WebCore/ChangeLog (working copy) | |
| @@ -1,3 +1,16 @@ | |
| +2012-02-09 Benjamin Poulain <[email protected]> | |
| + | |
| + The localization of htmlSelectMultipleItems() needs better support of pluralization | |
| + https://bugs.webkit.org/show_bug.cgi?id=78197 | |
| + |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| From a3ca019fd9300883d5e56beac98150cb1bcfff6e Mon Sep 17 00:00:00 2001 | |
| From: Benjamin Poulain <[email protected]> | |
| Date: Sat, 3 Sep 2011 16:09:02 +0200 | |
| Subject: [PATCH] Matches all the statements that can be present in the | |
| header. | |
| --- | |
| Callgrind Viewer/FileLoader.m | 70 ++++++++++++++++++++++++++++++++++++++-- | |
| 1 files changed, 66 insertions(+), 4 deletions(-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| From b23bd097bd114389754f91f89a0a22098f790fed Mon Sep 17 00:00:00 2001 | |
| From: Benjamin Poulain <[email protected]> | |
| Date: Thu, 1 Sep 2011 21:56:43 +0200 | |
| Subject: [PATCH 2/7] Pass the information loaded by the FileLoader to the | |
| document and update the UI accordingly | |
| When the file loader has finished loading the data, pass the information back to the client. Currently, | |
| only the command name is read and passed to NSDocument. The display name is update accordingly | |
| so that the window title show the command that was being profiled by Valgrind. | |
| --- |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| From b04c392ecf5b3c097b4d2a06502193e237d681c4 Mon Sep 17 00:00:00 2001 | |
| From: Benjamin Poulain <[email protected]> | |
| Date: Thu, 1 Sep 2011 19:32:04 +0200 | |
| Subject: [PATCH] Add basic parsing for the command header. | |
| The "cmd:" header represent the command profiled by Valgrind. | |
| --- | |
| Callgrind Viewer/FileLoader.m | 21 +++++++++++++++++++++ | |
| 1 files changed, 21 insertions(+), 0 deletions(-) |