diff --git a/src/node_file.cc b/src/node_file.cc
index 89c53afc5b..f81433e53c 100644
--- a/src/node_file.cc
+++ b/src/node_file.cc
@@ -612,7 +612,7 @@ template <typename Func, typename... Args>
inline FSReqBase* AsyncDestCall(Environment* env,
FSReqBase* req_wrap,
const FunctionCallbackInfo<Value>& args,
- const char* syscall, const char* dest, size_t len,
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
About writing a test: | |
The tests here work the same as if you would write code for your own project. So what you want to do is to write some code that would actually fail without this change. I guess you should know how to get there as you found out that it does not always emit a close when finishing. | |
The only difference here is that you have to include the "common" part as first require statement as done in every test file in the test folder. You probably want to add a new file in the "parallel" part. | |
In addition to that you have some extra helper functions that you find in the common part and that also has a individual documentation. But you should probably not need that at all. | |
To run the tests you first have to build the node executable (I guess you use a unix system, so run make -j4. On Windows it is something with the bat file ;-) ). | |
When that is done (it could take a while when doing it for the first time...) you can run the tests by running make -j4 test or only your test file with: python ./tools/ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
'use strict' | |
const assert = require('assert') | |
const fs = require('fs') | |
const util = require('util') | |
function promiseMapOrdered(arr, mapper, concurrency) { | |
// Do not use an `async` function! Otherwise the promise constructor won't | |
// notice sync errors. | |
return new Promise((resolve, reject) => { |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
'use strict' | |
const testData = [ { _id: '5a660b85cc23d42973bb8f61', | |
index: 0, | |
guid: 'cbd5519b-24d2-479b-bd07-c6d676d350e7', | |
isActive: true, | |
balance: '$3,182.51', | |
picture: 'http://placehold.it/32x32', | |
age: 37, | |
eyeColor: 'brown', |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* [[`4c317ce4d0`](https://github.com/nodejs/node/commit/4c317ce4d0)] - **(SEMVER-MINOR)** **child_process,cluster**: allow using V8 serialization API (Anna Henningsen) [#30162](https://github.com/nodejs/node/pull/30162) | |
* [[`7bfc339c47`](https://github.com/nodejs/node/commit/7bfc339c47)] - **(SEMVER-MINOR)** **cli**: add --trace-exit cli option (legendecas) [#30516](https://github.com/nodejs/node/pull/30516) | |
* [[`f3196db13f`](https://github.com/nodejs/node/commit/f3196db13f)] - **(SEMVER-MINOR)** **cli**: whitelist new V8 flag in NODE\_OPTIONS (Shelley Vohr) [#30094](https://github.com/nodejs/node/pull/30094) | |
* [[`e08c008b5d`](https://github.com/nodejs/node/commit/e08c008b5d)] - **(SEMVER-MINOR)** **cli**: add --trace-uncaught flag (Anna Henningsen) [#30025](https://github.com/nodejs/node/pull/30025) | |
* [[`f8d3ea987d`](https://github.com/nodejs/node/commit/f8d3ea987d)] - **(SEMVER-MINOR)** **crypto**: add support for IEEE-P1363 DSA signatures (Tobias Nießen) [#29292](https://github.com/nodejs/node/pull/29292) |