Dil3mm4

From 259776bd0218af032d5b2116af0069e105233e24 Mon Sep 17 00:00:00 2001
From: Dil3mm4 <[email protected]>
Date: Fri, 4 Dec 2020 18:42:54 +0000
Subject: [PATCH] SystemUI: ensure keyguardstatusbar is hidden if not on
 keyguard

There seem to be some un-identified weird cases where the various runnable aren't execute by keyguard dismissal, therefore let's be sure mKeyguardStatusBar status is correct on view reinflation.

diff --git a/packages/SystemUI/src/com/android/systemui/statusbar/phone/NotificationPanelViewController.java b/packages/SystemUI/src/com/android/systemui/statusbar/phone/NotificationPanelViewController.java
index 48aeb0fd93d6..4300556e1325 100644

Dil3mm4

From 743d939ee44423503c135887d3fd221122ec10e7 Mon Sep 17 00:00:00 2001
From: Dil3mm4 <[email protected]>
Date: Fri, 4 Dec 2020 18:42:54 +0000
Subject: [PATCH] SystemUI: ensure keyguardstatusview is hidden if not on
 keyguard

There seem to be some un-identified weird cases where the various runnable aren't execute by keyguard dismissal, therefore let's be sure mKeyguardStatusBar status is correct on view reinflation.

diff --git a/packages/SystemUI/src/com/android/systemui/statusbar/phone/NotificationPanelViewController.java b/packages/SystemUI/src/com/android/systemui/statusbar/phone/NotificationPanelViewController.java
index 48aeb0fd93d6..4300556e1325 100644

Dil3mm4

From 47d6c816c632e9c71763bdec1d93def08ffd5201 Mon Sep 17 00:00:00 2001
From: Dil3mm4 <[email protected]>
Date: Fri, 4 Dec 2020 17:01:10 +0000
Subject: [PATCH] GlobalActionsDialog: address FOD on-top of powermenu

Due to FOD window type being TYPE_DISPLAY_OVERLAY, when spawning GlobalActions dialogs, FOD would always be on top.
Fix this behaviour assigning FOD window type to any GlobalActions windows.

Tests:
    - trigger FODCircleView to show, launch GlobalActions, observe FOD stays in background

Dil3mm4

From da934ae53fc57e3fc822478c302825971602d7af Mon Sep 17 00:00:00 2001
From: Dil3mm4 <[email protected]>
Date: Thu, 3 Dec 2020 16:39:34 +0000
Subject: [PATCH] LockIcon: refresh icon onThemeChanged


diff --git a/packages/SystemUI/src/com/android/systemui/statusbar/phone/LockIcon.java b/packages/SystemUI/src/com/android/systemui/statusbar/phone/LockIcon.java
index 585795502625..da0950228114 100644
--- a/packages/SystemUI/src/com/android/systemui/statusbar/phone/LockIcon.java
+++ b/packages/SystemUI/src/com/android/systemui/statusbar/phone/LockIcon.java

Dil3mm4

From 9598e760d39fd92bd103fad17bb412c1438b5701 Mon Sep 17 00:00:00 2001
From: Dil3mm4 <[email protected]>
Date: Wed, 2 Dec 2020 00:28:32 +0000
Subject: [PATCH] SystemUI - FODCircleViewImpl: handle cases that we can't
 address within FODCircleView

So, briefly, what went on in this pow-wow is:
    - created a callback to efficiently monitor calls to FODCircleView impl (LuK1377 had a lot of patience)
    - addressed FOD visibility on statusbar expansion/collapse checking top activity package name and class within StatusBar.java
    - addressed FOD visibility if an app gets launched after statusbar expansion from a notif

Dil3mm4

From 961d3814e2df872f8f16271477065341b329c1a9 Mon Sep 17 00:00:00 2001
From: Dil3mm4 <[email protected]>
Date: Wed, 2 Dec 2020 00:28:32 +0000
Subject: [PATCH] SystemUI - FODCircleViewImpl: handle cases that we can't
 address within FODCircleView

So, briefly, what went on in this pow-wow is:
    - created a callback to efficiently monitor calls to FODCircleView impl (LuK1377 had a lot of patience)
    - addressed FOD visibility on statusbar expansion/collapse checking top activity package name and class within StatusBar.java
    - addressed FOD visibility if an app gets launched after statusbar expansion from a notif

Dil3mm4

From bc68ef6273307143a78788c068af1adde6fbc9d3 Mon Sep 17 00:00:00 2001
From: Dil3mm4 <[email protected]>
Date: Mon, 30 Nov 2020 16:38:58 +0000
Subject: [PATCH] FODCircleView: change window type based on foreground status

To avoid clashes with other UI elements once a third party app (or Settings) request biometric unlocks, we need to change the window type accordingly.

Tests:
    - open third party app that requests biometric (or Settings enrollment fragment), expand qs, observe FOD is in background

Dil3mm4

From a03c1443438111467cb3e2796019b96531e3f3a8 Mon Sep 17 00:00:00 2001
From: Dil3mm4 <[email protected]>
Date: Mon, 30 Nov 2020 04:31:41 +0000
Subject: [PATCH] FODCircleView && KeyguardSecurityContainer: don't show FOD if
 a strong auth is required && don't setup bottommargin if strong auth is
 required

---
 .../src/com/android/keyguard/KeyguardSecurityContainer.java    | 3 +--
 .../src/com/android/systemui/biometrics/FODCircleView.java     | 3 +++

Dil3mm4

From 66a95e5a5f04e07673f4a6ba5017f2f12f0a435c Mon Sep 17 00:00:00 2001
From: Dil3mm4 <[email protected]>
Date: Sat, 28 Nov 2020 05:24:03 +0000
Subject: [PATCH 2/2] FODCircleView: differentiate window type per scenario

With this commit we're going to avoid weird FOD states where it dismisses lately/gets stuck occluding the background view (soon to become foreground/in the act of transitioning to foreground).

Ex. video before the patch:
Ex. video after the patch:

Dil3mm4

From 642f78576b724f45bd7072ad386cd32eec57fd8b Mon Sep 17 00:00:00 2001
From: Dil3mm4 <[email protected]>
Date: Sat, 28 Nov 2020 01:07:31 +0000
Subject: [PATCH 1/2] FODCircleView: don't hide if
 mUpdateMonitor.isFingerprintDetectionRunning() is false

This solves an edge-case (described in the test below) without affecting FOD correct functionality.
We have reliable ways to hide the view in any case.

Tests: