Tarun Pothulapati Pothulapati

So, Add-on Model is planned to be done using helm charts as the underlying tool. The following constraints are present because of that:

Sub-charts will live under charts/add-ons as new Helm charts with similar format and templating. As helm supports URL as the repo path for add-ons, They can also later be moved out-of-tree totally.
The values of the sub-charts will be overriden by using the name of the add-on field in the parent's i.e linkerd2's values.yaml. These values are considered the defaults and can be overriden using cli or a new values file. charts/add-ons/grafana/values.yaml can left out empty so that we can maintain the config centrally.
The requirements.yaml will be updated to have the dependencies. Ex:

dependencies:
- name: partials

	apiVersion: split.smi-spec.io/v1alpha1
	kind: TrafficSplit
	metadata:
	name: foobar-rollout
	spec:
	service: reviews
	backends:
	- service: reviews-v2
	weight: 500m
	- service: reviews-v3

	apiVersion: v1
	kind: Namespace
	metadata:
	name: istio-system
	labels:
	istio-injection: disabled
	---
	apiVersion: apiextensions.k8s.io/v1beta1
	kind: CustomResourceDefinition
	metadata:

	apiVersion: v1
	kind: Namespace
	metadata:
	name: istio-system
	labels:
	istio-injection: disabled
	---
	apiVersion: apiextensions.k8s.io/v1beta1
	kind: CustomResourceDefinition
	metadata:

	#!/bin/bash

	set -eu

	if [ $# -ne 0 ]; then
	echo "no arguments allowed for ${0##/}, given: $" >&2
	exit 64
	fi

	bindir=$( cd "${BASH_SOURCE[0]%/*}" && pwd )