Psilon Pzixel

Code review strategies

Here are several strategies to keep in mind when reviewing submissions that, for whatever reason, you (as a project maintainer) do not like:

Rephrase your objection as a question

Bad: "This change will make XXX impossible." (This is hyperbole; is it really impossible?) Good: "How can we do XXX with your change?"

	using System;
	using System.Threading;
	using System.Threading.Tasks;

	namespace Utils
	{
	public class AsyncLock<T> where T : class
	{
	public bool IsDeconstructed { get; private set; }
	private readonly SemaphoreSlim _semaphore;

	{-# LANGUAGE DataKinds #-}
	{-# LANGUAGE GADTs #-}
	{-# LANGUAGE KindSignatures #-}
	{-# LANGUAGE PolyKinds #-}
	{-# LANGUAGE RankNTypes #-}
	{-# LANGUAGE ScopedTypeVariables #-}
	{-# LANGUAGE TypeApplications #-}
	{-# LANGUAGE TypeOperators #-}
	module Main where

	Пробирка Колина Пауэлла и "легальность" нападения на Ирак

	В интернетах часто любят упоминать пресловутую пробирку которой Колин Пауэлл тряс перед вторжением в Ирак -- якобы он говорил что в ней находятся образцы иракского ОМП, и потому надо немедленно воевать.

	Так вот, сначала немного вводных данных. Ко времени вторжения в Ирак у ООН всё еще не было данных о судьбе некоторых частей оружейной программы Ирака. За подробностями об инспекциях и полученной информации можно посмотреть документы [UNSCOM](http://www.un.org/depts/unscom/unscmdoc.htm) и [UNMOVIC](http://www.unmovic.org/).

	*UNMOVIC Twelfth Quarterly Report UN document S/2003/232 of 28 February 2003
	*

	As there is little new substantive information in the weapons part of Iraq’s declaration, or new supporting documentation, the issues that were identified as unresolved in the Amorim report (S/1999/356) and in UNSCOM's report (S/1999/94) remain.

	export const decodeArg = (web3: Web3, hexString: string, solidityType: string, offsetInBytes: number, lengthInBytes: number): any => {
	if (lengthInBytes > 32) {
	throw new Error('Cannot decode types >32 bytes length');
	}
	const zxoffset = hexString.startsWith('0x') ? 2 : 0;
	const zeroedLength = 32 - lengthInBytes;
	return web3.eth.abi.decodeParameter(solidityType, '00'.repeat(zeroedLength) + hexString.slice(zxoffset + offsetInBytes * 2, zxoffset + (offsetInBytes + lengthInBytes) * 2));
	};

	export const decodePackedArgs = (web3: Web3, hexString: string, typeMetadatas: [string, number][]) => {

	using System;
	using System.Linq;
	using System.Linq.Expressions;
	using Microsoft.AspNet.OData;
	using Microsoft.AspNet.OData.Builder;
	using Microsoft.AspNet.OData.Extensions;
	using Microsoft.AspNet.OData.Formatter;
	using Microsoft.AspNetCore.Builder;
	using Microsoft.Extensions.DependencyInjection;
	using Microsoft.Net.Http.Headers;

	#include <math.h>

	#ifdef USE_RESTRICT
	#else
	#define __restrict
	#endif


	void transform (float * __restrict dest, float * __restrict src,
	float * __restrict matrix, int n) __attribute__ ((noinline));