-
Coding is work. Reviewing is, also, work. The added value of the code resides in its usage. Code is used when merged, merged when reviewed. So keep in mind that reviewing is adding value.
-
Every member of the team should have at least one dedicated time slot (two or more is more healthy) during his regular working day to perform code reviews. For example, at the beginning of the day, before starting something else, take a tour of GitHub. In the same way, when coming back from lunch.
-
To know what is waiting for a review, the Review Request can be helpful (but sometimes too noisy). Take time to configure your Notifications, it worths it.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
email.trim().replace(/^(.*?)(?:\+.*?)?(@gmail\.com)$/gi, '$1$2').replace(/\.(?!com$)/g, ''); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
function isFunction(potentialFunction) { | |
return potentialFunction && Object.prototype.toString.call(potentialFunction) === '[object Function]'; | |
} | |
function stringsReplace(str, callback) { | |
if (isFunction(callback)) { | |
str.replace(/(["'`])((?:(?=(\\?))\3.)*?)\1/gmi, (all, quote, value) => callback(value)); | |
} | |
return str.replace(mustacheRegex, callback); | |
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#!/usr/bin/env bash | |
diffInitial=`git diff --name-only --diff-filter=ACMR` | |
BLUE='\033[0;34m' | |
RED='\033[0;31m' | |
RESET='\033[0m' | |
package=`git diff --cached --name-only --diff-filter=ACMR | grep -E "package.json$"` | |
js=`git diff --cached --name-only --diff-filter=ACMR | grep -E "jsx?$"` |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#!/usr/bin/env bash | |
git_is_inside() { | |
git rev-parse --is-inside-work-tree 2>&1 | |
} | |
git_root() { | |
if [[ $(git_is_inside) != "true" ]]; then | |
pwd | |
return |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#!/usr/bin/env bash | |
set -o nounset -o pipefail -o errexit | |
main() { | |
local INSTALL_PATH="${HOME}/code" | |
local GITHUB_USER="ViBiOh" | |
local DOTFILES_NAME="dotfiles" | |
local DOTFILES_BRANCH="main" | |
local ARCHIVE_FILENAME="${INSTALL_PATH}/dotfiles.zip" |
- Go on https://github.com/settings/replies
- Open the developer console and run the following script
{
const LABELS = [
["👏 praise", "Praises highlight something positive. Try to leave at least one of these comments per review. Do not leave false praise (which can actually be damaging). Do look for something to sincerely praise."],
["🥜 nitpick", " Nitpicks are trivial preference-based requests. These should be non-blocking by nature."],