You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I want to run through a few hypothetical scenarios because I'm still not 100% confident I understand how breaking changes will be handled in theme.json and also block.json.
This is an exploration of how theme.json could work in the future—my dream theme.json, if you will. A tour of the new theme.json can be found in theme-v2.json. theme-v1.json is provided for reference to see where properties have moved.
The theme.json files are quite long, so it may be helpful to clone the gist and view the files in a proper editor with code folding.
This gist is more of a living document than a static thing, and there are still a lot of unanswered questions that I'm still working through. I'm pretty happy with the general structure at this point, but there are a few opportunities for things to be added or removed. This is mostly documented in the Unanswered Questions section of this README.
The original prototype used react-image-crop for the cropping library. We decided that the zoom-crop interaction was more important, so we went with react-easy-crop instead. It seemed like it would be easier to add freeform crop to the zoom-crop library than add zoom crop to the freeform library.
Existing rotation+zoom bug
After we landed the feature, we found a bug involving rotation+zoom. I gave it a go and quickly realized that fixing that would fundamentally change how the zoom-crop mechanism worked.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters