Mara Averick batpigandme

Package Review

Please check off boxes as applicable, and elaborate in comments below. Your review is not limited to these topics, as described in the reviewer guide

As the reviewer I confirm that there are no conflicts of interest for me to review this work (such as being a major contributor to the software).

Documentation

The package includes all the following forms of documentation:

Keybase proof

I hereby claim:

I am batpigandme on github.
I am maraaverick (https://keybase.io/maraaverick) on keybase.
I have a public key ASBGZYlMVMOAmXm5NnWjniIDny002jlVi144EAtWkvcz9wo

To claim this, I am signing this object:

	## visualize team point leads and outcomes with small multiples

	## install and load ggplot2
	install.packages("ggplot2")
	library(ggplot2)

	## make separate point plots for each team
	ggplot(teamgame_point_leads, aes(x=final_point_diff, y=points_biggest_lead)) + geom_point() +
	facet_wrap(~team_slug)

	## steph curry's three-point shooting data from
	## stattleship api

	## density plot of three-pt pctg
	d <- density(steph_gls$three_pointers_pct)
	plot(d, type="n", main="three point percentage")
	polygon(d, col="red", border="gray")

	## histograms
	hist(steph_gls$three_pointers_attempted)


	│ three_pointers_attempted │ three_pointers_made │ three_pointers_pct │
	├──────────────────────────┼─────────────────────┼────────────────────┤
	│ Min. : 4.00 │ Min. : 1.000 │ Min. :0.1110 │
	│ 1st Qu.: 9.00 │ 1st Qu.: 3.000 │ 1st Qu.:0.3407 │
	│ Median :11.00 │ Median : 5.000 │ Median :0.4550 │
	│ Mean :10.81 │ Mean : 4.926 │ Mean :0.4401 │
	│ 3rd Qu.:13.00 │ 3rd Qu.: 7.000 │ 3rd Qu.:0.5000 │
	│ Max. :16.00 │ Max. :11.000 │ Max. :0.7330 │

	## install and load the stattleshipR package
	devtools::install_github("stattleship/stattleship-r")
	library(stattleshipR)

	## optional: load dplyr
	library(dplyr)

	## get your API token stattleship.com
	## set API token
	set_token('YOUR API TOKEN')

	##################################
	## Getting Team Preseason Stats ##
	##################################

	## set strings as factors to false
	options(stringsAsFactors = FALSE)

	## load libraries
	library(stattleshipR)
	library(dtplyr)

	Error in mutate_impl(.data, dots) : STRING_ELT() can only be applied to a 'character vector', not a 'NULL'
	26.
	mutate_impl(.data, dots)
	25.
	mutate.tbl_df(., instance = row_number(term))
	24.
	mutate(., instance = row_number(term))
	23.
	function_list[[1L]](value)
	22.

	* installing source package ‘nbastatR’ ...
	** R
	** tests
	** preparing package for lazy loading
	Error in loadNamespace(i, c(lib.loc, .libPaths()), versionCheck = vI[[i]]) :
	there is no package called ‘curlconverter’
	ERROR: lazy loading failed for package ‘nbastatR’
	* removing ‘/Users/maraaverick/Library/R/3.3/library/nbastatR’
	Error: Command failed (1)

	d3pct <- density(steph_gls$three_pointers_pct)
	plot(d3pct)