- A quick glance at the diff to spot anything obvious
- Pull it down and run it locally with a fresh install of all dependencies
- open the console and watch for errors being logged
- does this patch cover the AC in the story?
- does this patch resolve repro steps in the bug/defect?
- Comb through code line by line:
- Are there sanity checks in place (no infinite loops/recursion, etc)?
- If there's complex or hard to follow code, can it be simplified?
brian ruddy bcruddy
bcruddy
/ reddit-unsubscribe-all.js
Last active
March 2, 2017 08:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| /* | |
| * javascript to unsubscribe from all default subs | |
| * navigate to https://www.reddit.com/subreddits and then copy/paste the below snippet in the console | |
| * Tested in chrome 56, minimum browser reqs: | |
| * https://developer.mozilla.org/en-US/docs/Web/API/NodeList/forEach#AutoCompatibilityTable | |
| * http://caniuse.com/#feat=arrow-functions | |
| */ | |
| document.querySelectorAll('a.option.remove').forEach(a => a.click()) |
bcruddy
/ magic-table.css
Last active
March 24, 2017 19:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @media screen and (max-width: 767px) { | |
| table.table-magic { border: 0; } | |
| table.table-magic thead { display: none; } | |
| table.table-magic tr { margin-bottom: 10px; display: block; border: 1px solid #ddd; border-bottom: 2px solid #ddd; } | |
| table.table-magic td { display: block; position: relative; text-align: right; font-size: 13px; border-bottom: 1px dotted #ccc; } | |
| table.table-magic td:last-child { border-bottom: 0; } | |
| table.table-magic td:before { content: attr(data-label); position: absolute; left: 5px; text-transform: uppercase; font-weight: bold; } | |
| } |
bcruddy
/ SearchKit-React.PropTypes_master
Created
April 25, 2017 12:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| src/__test__/core/react/RenderComponentSpec.tsx:25: color:React.PropTypes.string | |
| src/__test__/core/react/RenderComponentSpec.tsx:42: color:React.PropTypes.string | |
| src/__test__/core/react/RenderComponentSpec.tsx:47: color: React.PropTypes.string | |
| src/components/display/view-switcher/ViewSwitcherHits.tsx:31: hitComponents:React.PropTypes.arrayOf( | |
| src/components/display/view-switcher/ViewSwitcherHits.tsx:32: React.PropTypes.shape({ | |
| src/components/display/view-switcher/ViewSwitcherHits.tsx:33: key:React.PropTypes.string.isRequired, | |
| src/components/display/view-switcher/ViewSwitcherHits.tsx:34: title:React.PropTypes.string.isRequired, | |
| src/components/display/view-switcher/ViewSwitcherHits.tsx:37: defaultOption:React.PropTypes.bool | |
| src/components/search/filters/checkbox-filter/CheckboxFilter.tsx:32: id: React.PropTypes.string.isRequired, | |
| src/components/search/filters/checkbox-filter/CheckboxFilter.tsx:33: title: React.PropTypes.string.isRequired, |
bcruddy
/ SearchKit-React.PropTypes_develop
Last active
April 9, 2019 11:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| src/__test__/core/react/RenderComponentSpec.tsx:25: color:React.PropTypes.string | |
| src/__test__/core/react/RenderComponentSpec.tsx:42: color:React.PropTypes.string | |
| src/__test__/core/react/RenderComponentSpec.tsx:47: color: React.PropTypes.string | |
| src/components/display/view-switcher/ViewSwitcherHits.tsx:30: hitComponents:React.PropTypes.arrayOf( | |
| src/components/display/view-switcher/ViewSwitcherHits.tsx:31: React.PropTypes.shape({ | |
| src/components/display/view-switcher/ViewSwitcherHits.tsx:32: key:React.PropTypes.string.isRequired, | |
| src/components/display/view-switcher/ViewSwitcherHits.tsx:33: title:React.PropTypes.string.isRequired, | |
| src/components/display/view-switcher/ViewSwitcherHits.tsx:36: defaultOption:React.PropTypes.bool | |
| src/components/search/filters/checkbox-filter/CheckboxFilter.tsx:32: id: React.PropTypes.string.isRequired, | |
| src/components/search/filters/checkbox-filter/CheckboxFilter.tsx:33: title: React.PropTypes.string.isRequired, |
bcruddy
/ min-spa-html
Created
April 26, 2017 15:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| <!DOCTYPE html> | |
| <html> | |
| <head> | |
| <title>whatever</title> | |
| </head> | |
| <body> | |
| <div id="app"></div> | |
| <!-- scripts (including ember and it's templates) --> | |
| </body> | |
| </html> |
bcruddy
/ travis-yarn-output
Created
May 31, 2017 13:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| $ node --version | |
| v6.9.1 | |
| $ npm --version | |
| 3.10.8 | |
| $ nvm --version | |
| 0.23.3 | |
| Installing yarn | |
| 255.48s$ curl -o- -L https://yarnpkg.com/install.sh | bash | |
| % Total % Received % Xferd Average Speed Time Time Time Current | |
| Dload Upload Total Spent Left Speed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| [36mBuilt-in Atom Packages[39m (90) | |
| ├── [email protected] | |
| ├── [email protected] | |
| ├── [email protected] | |
| ├── [email protected] | |
| ├── [email protected] | |
| ├── [email protected] | |
| ├── [email protected] | |
| ├── [email protected] | |
| ├── [email protected] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| adns | |
| ansible | |
| autoconf | |
| automake | |
| bash-completion | |
| cairo | |
| cf-cli | |
| composer | |
| coreutils | |
| dirmngr |
bcruddy
/ macbook-setup.txt
Last active
March 19, 2018 13:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| This is how I'd set up a brand new macbook, I'll try to note what's required and what's optional | |
| Required(ish): | |
| Show hidden files (dotfiles) - http://www.macworld.co.uk/how-to/mac-software/how-show-hidden-files-in-mac-os-x-finder-funter-macos-sierra-3520878/ | |
| Install homebrew - https://brew.sh/ | |
| Install non-apple git - $ brew install git | |
| Check to make sure you have ruby installed (ruby -v) and then run `gem install bundler` -> if you choose to install RVM, do that first | |
| Install nvm WITH HOMEBREW - http://dev.topheman.com/install-nvm-with-homebrew-to-use-multiple-versions-of-node-and-iojs-easily/ | |
| Optional: |
bcruddy
/ good-code-reviews.md
Last active
February 17, 2020 16:54