Skip to content

Instantly share code, notes, and snippets.

View bucker's full-sized avatar

susi bucker

  • Google
  • Taiwan
View GitHub Profile
@bucker
bucker / .gitignore
Last active September 7, 2019 13:01 — forked from keyboardsurfer/.gitignore
# Copyright: Benjamin Weiss (keyboardsurfer) https://github.com/keyboardsurfer
# Under CC-BY-SA V3.0 (https://creativecommons.org/licenses/by-sa/3.0/legalcode)
# built application files
*.apk
*.ap_
# lint folder
lint
@bucker
bucker / code_review_checklist.txt
Last active December 4, 2020 16:28 — forked from kashifrazzaqui/code_review_checklist.txt
Code Review Checklist
## General
[ ] The code works
[ ] Follows coding conventions
[ ] There are no usages of 'magic numbers'
[ ] All variables are in the smallest scope possible
[ ] All class, variable, and method modifiers are correct.
[ ] There is no dead code (inaccessible at Runtime)
[ ] No code can be replaced with library functions
[ ] Required logs are present
[ ] No debugging code, no System.out.print, no stack traces info