delbetu

#Why messy code kill companies ?

##Example story At the start of a project when everything is clean you are going fast!

People ask for new things you could get that done in a matter of hours or days.

A year later things had to slow

The harder and harder you work the slower and slower things seems to go, why ??

delbetu

##Example Service

  angular.module('sportAdmin')
    .factory('Tournament', function($resource, $q) {

      var baseUrl = '/api/tournaments/:tournamentId'

      var service = $resource(baseUrl, {tournamentId: '@id'})

delbetu

Example Controller

    angular.module('sportAdmin')
      .controller('TournamentListController', function ($scope, Tournament, Sports, Alerts) {

        this.getTournaments = function(){
          this.tournaments = Tournament.all()
          this.sports = Sports.all()
          this.organization = $scope.organization
        }

delbetu

Cross-Site Scripting (XSS)

User injects client side executable code. User can add js-malicious code within user input boxes, parameters or cookies

HTML/JS injection

this
<script>alert('Hello');</script>
is the same as this

delbetu

# Procedural (Mutation and data separated from code)
# OO (Mutation and data combined with code)
# Functional Version (Imutability and data separated from code)
# FauxO Version (Immutability and data combined with code)

#Procedural-we have knowledge of the internals
def feeding_time
  walruses.each do |walrus|
    walrus.stomach << Cheese.new
  end

delbetu

Comments

every time you write a comment you failed. commented out code is an abomination that must be destroy before it spreads.

Formatting

white space discipline is important Be consistent horizontal scrolls will not be tolerated(between 40 and 120 columns) keep file sizes under control average between 100 lines and never exceed 500

delbetu

  context 'Test all instance methods' do

    let(:test_user) { create(:th_user) }
    let(:superbadge) do
      create(
        :th_superbadge,
        api_name: 'test_super_badge',
        first_ascent_points: 1000,
        completion_points: 1000
      )

delbetu

class UniquenessValidator
  def initialize(sources: [])
    @sources = sources
  end

  def run
    # 'admin_intro_crm_basics', 'lex_migration_introduction', 'admin_intro_crm_basics'
    top_level_ids = sources.map(&:find_all_top_level_ids).flatten
    calculate_repeated!(top_level_ids)
    self

delbetu

class IsolatedCode
  def initialize(release_being_sent = { state: 'published' },
                 release)
    @release_being_sent = release_being_sent
    @release = release
  end

  def foo
    ActiveRecord::Base.transaction do
      if publishing?

delbetu

class BarService
  def foo(input_data)
   ...
     if input_data.page
        num = 45
        output_data.notified_at_offset = notification_data_access.notified_at(input_data.page)
      else
        num = 10
      end
      output_data.notifications =