Dennis Oelkers dennisoelkers

I hereby claim:

I am dennisoelkers on github.
I am dns42 (https://keybase.io/dns42) on keybase.
I have a public key whose fingerprint is BB44 454B DCD2 B9B3 2922 A73D 26B2 C114 209D C497

To claim this, I am signing this object:

Expectations from a PR review

both gatekeeping and editing
- preventing incorrect, insecure, maintainable code from entering the codebase
- providing advice and suggestions for potential improvements concerning readability, best practices/conventions, abstraction and/or performance
PR review is based on the assumption that any written code benefits from being looked at through the perspective of another person with a different expertise & focus
PR reviews are feedback on the code, never feedback on the person who wrote it

	node.js:134
	throw e; // process.nextTick error, or 'error' event on first tick
	^
	Error: EADDRINUSE, Address already in use
	at doConnect (net.js:549:5)
	at net.js:725:9
	at dns.js:192:7
	at Object.lookup (dns.js:190:11)
	at Socket.connect (net.js:712:20)
	at Object.createConnection (net.js:265:5)

	public class DBAdapterBindings extends PluginModule {
	@Override
	protected void configure() {
	addPeriodical(DBAdapter.class);
	}
	}

	// @flow strict
	import * as Immutable from 'immutable';

	type InternalState = {
	id: string,
	};

	export type ${NAME}JSON = {
	id: string,
	};

	#!/bin/sh

	# Polling the status checks for a PR and merges it when they are green.
	# Needs to be executed in the directory of the PR's repo.
	#
	# Args: merge-on-green <PR>
	# where PR is the number of the PR without "#"
	#

	PR_NO=$1

	#!/bin/sh

	# Returning the status of all open PRs of $1, execute it in the directory of the git repository
	# Perfect in combination with `watch -n 30 -c pr-check`

	GITHUB_USER=dennisoelkers
	if [ "$1" != "" ]; then
	GITHUB_USER=$1
	fi

	#!/bin/sh

	GITHUB_USER=dennisoelkers
	if [ "$1" != "" ]; then
	GITHUB_USER=$1
	fi

	echo "PRs asking me for review:\n"

	for i in `hub pr list -s open -o update -f '%i;%sH;%H;%U;%ut;%rs%n'\|sed 's/ //g'\|grep ${GITHUB_USER}`; do