dylanberry

Agenda

• Finish rebase
• Touch-up pull request

Notes

• Rebase
  • Commits are replayed one at a time
  • Resolving a conflict in a commit may cause cascading conflicts in future commits
  • To complete the rebase process, you must force push
• Consider different tools - GitKraken

dylanberry

public class BaseTabViewModel : BaseViewModel, IActiveAware
{
    // NOTE: Prism.Forms only sets IsActive, and does not do anything with the event.
    public BaseTabViewModel(INavigationService navigationService, 
        IViewModelServiceProvider viewModelServiceProvider) 
        : base(navigationService, viewModelServiceProvider)
    {
        var onIsActiveChanged = new WeakEventHandler<EventArgs>(OnIsActiveChanged);
        IsActiveChanged += onIsActiveChanged.Handler;
        

dylanberry

Agenda

• Fix issues identified in PageNavigationService
• Write UI tests!

Notes

• if Visual Studio for Mac will not build/run due to XAMLC issues, clean, delete output and quit/restart VS

What did we do?

• Fixed (not really) VS XAMLC headache
• Debugged PageNavigationService, found/fixed an unawaited async call

dylanberry

Agenda

• Build pages for tabbed navigation scenario in test "HelloWorld" project
• Examine existing UI tests
• Build new UI tests

What did we do?

• Looked Prism modules for the first time!
• Brought our list/detail page into the HelloWorld/Module A project
• Added new dependencies into HelloWorld solution
• Explored existing UI Tests - ran successfully

dylanberry

    public static class TaskUtilities
    {
#pragma warning disable RECS0165 // Asynchronous methods should return a Task instead of void
        public static async void FireAndForgetSafeAsync(this Task task, Action<Exception> handleErrorAction = null)
#pragma warning restore RECS0165 // Asynchronous methods should return a Task instead of void
        {
            try
            {
                await task.ConfigureAwait(true);
            }

dylanberry

Agenda

• Functional testing
• Unit testing

Notes

• Give mfractor kudos for paste class functionality

dylanberry

Action Items

• Figure out F11 step into mapping for macOS (TM), currently mapped to system expose
• Share out styling/theme links https://github.com/StylishThemes https://github.com/mjswensen/themer (Credit to @depechie)
• Talk to Dan and Brian about renaming tests https://github.com/PrismLibrary/Prism/blob/07997a6097ddc4edea725047453e030ef272b0a9/tests/Forms/Prism.Forms.Tests/Navigation/PageNavigationServiceFixture.cs#L565
• Rider keys to Jon, Luis, Glenn

@dylbot9000

dylanberry

var tabbedPage = new TabbedPage();

tabbedPage.Children.Add(new ViewA());

var navigationPage = new NavigationPage(new ViewB());
tabbedPage.Children.Add(navigationPage);

// selectedTab=ViewB
tabbedPage.CurrentPage = navigationPage;

dylanberry

Notes From Dan

// This should result in a Tabbed Page with ViewA & ViewB as tabs and ViewB as the selected Tab...
// ViewC should be a Modal over the TabbedPage
NavigationService.NavigateAsync("TabbedPage?createTab=ViewA&createTab=ViewB&selectedTab=ViewB/ViewC");
// If we're improving things... then this should create a tab with a NavigationPage with the root ViewB and current page as ViewD...
// The select tab should be able to distinguish it by NavigationPage unless more than one tab has a NavigationPage..
// otherwise it should distinguish which tab by either the root or current which ever matches...
NavigationService.NavigateAsync("TabbedPage?createTab=ViewA&createTab=NavigationPage/ViewB/ViewC/ViewD&selectedTab={NavigationPage|ViewB|ViewD}");
// Second note here that was actually invalid and should not be supported... as the first actual `/` should be treated as an entirely new segment

dylanberry

public bool PromptToConfirmExit
{
    get
    {
        bool promptToConfirmExit = false;
        if (MainPage is ContentPage)
        {
            promptToConfirmExit = true;
        }
        else if (MainPage is Xamarin.Forms.MasterDetailPage masterDetailPage