-
-
Save eliperelman/1035982 to your computer and use it in GitHub Desktop.
String.prototype.trim polyfill for 140byt.es
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
function(){ | |
/* Rules: // make sure | |
(1) anonymous function // to annotate | |
(2) optionally self-executing // your code | |
(3) <140 bytes // so everyone | |
(4) no global vars // can learn | |
(5) MIT license // from it! | |
(6) good luck! | |
*/} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
function(){/*Rules: (1) anonymous function (2) may be self-executing (3) <=140 bytes (4) no globals (5) MIT license (6) have a good time!*/} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copyright (c) 2011 YOUR_NAME_HERE, YOUR_URL_HERE | |
Permission is hereby granted, free of charge, to any person obtaining | |
a copy of this software and associated documentation files (the | |
"Software"), to deal in the Software without restriction, including | |
without limitation the rights to use, copy, modify, merge, publish, | |
distribute, sublicense, and/or sell copies of the Software, and to | |
permit persons to whom the Software is furnished to do so, subject to | |
the following conditions: | |
The above copyright notice and this permission notice shall be | |
included in all copies or substantial portions of the Software. | |
THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, | |
EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF | |
MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND | |
NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE | |
LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION | |
OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION | |
WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
{ | |
"name": "sample", | |
"keywords": [ "sample", "original" ] | |
} |
Fixing the enumerable issue. I'm not sure yet if I can tackle making it any more robust as the character class alone to resolve the whitespace issue looks to be over 140 characters. I will research.
subzey commented in another gist of mine that the following regex might work: ^[\s\uFEFF]+|[\s\uFEFF]+$
. I will use it unless you think there is something non-compliant with it.
Did you happen to find any issues with the regex you implemented?
return this.replace(/^[\s\uFEFF\xA0]+|[\s\uFEFF\xA0]+$/g, '');
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The whitespace included in the character class
\s
is inconsistent across browsers. Instead a manual check of the required whitespace - is - best.Also browsers like Chrome have a bug where
String.prototype.trim = ''.trim
will causeString#trim
to become enumerable.