Skip to content

Instantly share code, notes, and snippets.

View fredemmott's full-sized avatar

Fred Emmott fredemmott

View GitHub Profile
diff --git a/_posts/2020-06-16-hhvm-4.62.markdown b/_posts/2020-06-16-hhvm-4.62.markdown
index 59c788d..4410fd4 100644
--- a/_posts/2020-06-16-hhvm-4.62.markdown
+++ b/_posts/2020-06-16-hhvm-4.62.markdown
@@ -25,6 +25,8 @@ and 4.56 LTS releases.
initialized with keys, or if Map or ImmMap are initialized without keys.
Previously, this would lead to a bytecode emitting error.
- FIXME codes now need whitelisting in the project root .hhconfig
+- FIXME whitelisting does not support `<?hh // partial`; as such, you are likely
+ to need to migrate any remaining partial code to `.hackpartial` files.
[
.errors[].message[]
| select(.descr | startswith("You cannot use HH_FIXME"))
| (
if .path | endswith(".hackpartial")
then { it: ., option: "allowed_fixme_codes_partial" }
else { it: ., option: "allowed_fixme_codes_strict" }
end
)
| (
[
.errors[].message[]
| select(.descr | startswith("You cannot use HH_FIXME"))
| (
if .path | endswith(".hackpartial")
then { it: ., option: "allowed_fixme_codes_partial" }
else { it: ., option: "allowed_fixme_codes_strict" }
end
)
| (
[
.errors[].message[]
| select(.descr | startswith("You cannot use HH_FIXME"))
| (
if .path | endswith(".hackpartial")
then { it: ., option: "allowed_fixme_codes_partial" }
else { it: ., option: "allowed_fixme_codes_strict" }
end
)
| (
fredemmott@fredemmott-fb /tmp % cat test.hack
<<__EntryPoint>>
function main(mixed $x): void {
$x->:foo;
}
fredemmott@fredemmott-fb /tmp % hh_single_compile test.hack
# test.hack starts here
.filepath "test.hack";
...
[2020-06-09 13:23:43.303] Running in check mode
allowed_fixme_codes_partial=4323
allowed_fixme_codes_strict=4110
diff --git a/hphp/hack/hhi/hsl/ext_hsl_os_subprocesses.hhi b/hphp/hack/hhi/hsl/ext_hsl_os_subprocesses.hhi
index 59f4eb477b..9a0d09b546 100644
--- a/hphp/hack/hhi/hsl/ext_hsl_os_subprocesses.hhi
+++ b/hphp/hack/hhi/hsl/ext_hsl_os_subprocesses.hhi
@@ -15,6 +15,7 @@ use type HH\Lib\OS\FileDescriptor;
type ForkAndExecveOptions = shape(
?'cwd' => string,
?'setsid' => bool,
+ ?'execvpe' => bool,
?'setpgid' => int,
diff --git a/src/html/PcdataElement.php b/src/html/PcdataElement.php
index 2646af0..a603d80 100644
--- a/src/html/PcdataElement.php
+++ b/src/html/PcdataElement.php
@@ -11,6 +11,13 @@
/**
* Subclasses of :xhp:pcdata-elements may contain only string children.
*/
+use namespace Facebook\XHP\ChildValidation as XHPChild;
+
<?hh // strict
/*
* Copyright (c) 2004-present, Facebook, Inc.
* All rights reserved.
*
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
*/
commit 45f46c67ab06976bc96265e55aa516a6336285cc
Author: Fred Emmott <fe@fb.com>
Date: Tue Feb 25 08:33:29 2020 -0800
codemod
diff --git a/src/children/XHPChildDeclarationConsistencyValidation.hack b/src/children/XHPChildDeclarationConsistencyValidation.hack
index 8010ed4..3e2e092 100644
--- a/src/children/XHPChildDeclarationConsistencyValidation.hack
+++ b/src/children/XHPChildDeclarationConsistencyValidation.hack