Total points: 10/10
Overall nice work. Good tests! Happy to see you writing code to verify your understanding of BCrypt.
You should add the loggedin property to the session when someone successfully signs
up for a new account. Right now you redirect someone to the "you logged in" page when
they sign up, but they're not really logged in. Accessing the secret page causes the
app to crash because there's no loggedin property set in the session.
| # Replace github usernames once with all students in class | |
| # force the class to all have the same name for their repos per assignment | |
| # pass the name of the repo to `d1cloner` to clone it for all the class. | |
| # This makes one directory for the assignment, with subdirectories of | |
| # students names with each students cloned repo. Make sure the students | |
| # merge their changes back to master so you have easy access. | |
| # | |
| # d1cloner data-structures-and-algorithms | |
| function d1cloner() { | |
| mkdir $1 |
res/xml/file_paths.xml
<?xml version="1.0" encoding="utf-8"?>
<paths xmlns:android="http://schemas.android.com/apk/res/android">
<external-path name="my_images" path="Android/data/com.example.moonmayor.firebasephotos/files/Pictures" />
</paths>AndroidManifest.xml
In your ProfileController you have a strange type for booleans.
You should prefer to use lower-case boolean when you make a
single boolean variable. You should only use upper-case Boolean
when you’re identifying the type of something in a generic class
between diamonds <Boolean>.
Boolean found = false;
Boolean endFound = false;
Awesome use of control characters to clear the terminal and reset the cursor postion. I was never doing that stuff in these classes. My programs always just printed out stuff over and over and over. So, pro stuff right there!
Bring the main method up so it is the first method to appear in the file.
Make more methods to encapsulate different parts of the main method. Think of the main method more as a table of contents than paragraphs of code explaining the program.
| // Credit to the original author | |
| // https://news.ycombinator.com/item?id=43835466 | |
| // https://gist.github.com/yayitswei/442cd5128b2dbfbd95a101b70f445183 | |
| let PIECE_ID = '927372' | |
| const TIMEOUT_DELAY = 10 | |
| const SQUARE_SIZE = 28 |