Gregg gmeluski

General

Unit tests: Review unit tests first. Unit tests are a fantastic way to grasp how code is meant to be used by others and to learn what the expected behavior is. Are there any test gaps that should be there?
Method arguments" Make sure arguments to methods make sense and are validated. Mentally test boundary conditions and edge cases.
Null References" (Yah yah, we know. Use F# and this goes away. We get it already.) Null references are a bitch and it’s worth looking out for them specifically.
Conventions Consistency" Make sure naming, formatting, etc. follow our conventions and are consistent. I like a codebase that’s fairly consistent so you know what to expect.
Disposables: Make sure disposable things are disposed. Look for usages of resources that should be disposed but are not.
Security: There is a whole threat and mitigation review process that falls under this bucket. In simple terms, ask yourself how this code could be exploited. The [STRIDE Threat Mo

	<!DOCTYPE html>
	<html>
	<head>
	<meta name="description" content="854byte synth - No HTML or CSS is needed. Everything is rendered by Javascript.">
	<meta charset="utf-8">
	<meta name="viewport" content="width=device-width">
	<title>854byte synth</title>
	</head>
	<body>
	<h1>854byte synth</h1>

	/* global document, require, setTimeout, phantom, console */
	var jsPerfTest = "for-loops-with-caching";
	var page = require("webpage").create();

	page.open("http://jsperf.com/" + jsPerfTest, function() {
	"use strict";

	setTimeout(function() {
	page.evaluate(function() {
	var ev = document.createEvent("MouseEvents");

	### Keybase proof

	I hereby claim:

	* I am gmeluski on github.
	* I am gmeluski (https://keybase.io/gmeluski) on keybase.
	* I have a public key whose fingerprint is AA7E F593 4C3F 0E56 E85D 0CF4 B1E8 EAA8 80FC BA31

	To claim this, I am signing this object: