gwilczynski

name: Security audit
on:
  schedule:
    - cron: '0 0 * * *'
  push:
    paths:
      - '**/Cargo.toml'
      - '**/Cargo.lock'
jobs:
  security_audit:

gwilczynski

Do not use forEach with async-await

TLDR: Use for...of instead of forEach in asynchronous code.

The problem

Array.prototype.forEach is not designed for asynchronous code. (It was not suitable for promises, and it is not suitable for async-await.)

For example, the following forEach loop might not do what it appears to do:

gwilczynski

import axios from "axios";

const getSomething = (url, onSucces, onError) => {
  axios
    .get(url)
    .then(result => {
      onSucces(result.data.results);
    })
    .catch(error => {
      onError(error);

gwilczynski

require 'benchmark'
require 'benchmark/ips'
require 'ostruct'
require 'active_model'

BillingAddressStruct = Struct.new(:street, :city, :zipcode, :country, :state)

BillingAddressOpenStruct = OpenStruct

BillingAddressStructFromHash = Struct.new(:street, :city, :zipcode, :country, :state) do

gwilczynski

require 'date'
require 'benchmark'

def real_time
  Benchmark.realtime do
    100000.times do
      yield
    end
  end
end