hhimanshu

Code Review Guidelines

In spirit of keeping our home (read codebase) clean and organized, we must have same protocol to talk.

Every pull request opened on the project needs to be scruitinzed on mutiple aspects. For example,

• How code is designed
• How code is formatted.
• How code structure is created

hhimanshu

System.out.println("Hello World!");

hhimanshu

import scala.collection.mutable

object Calculator {

  def main(args: Array[String]): Unit =
    if (args.length != 1) {
      throw new IllegalArgumentException("usage: Calculator <expression>")
    } else {
      val expression = args(0)
      val tokens = expression.split(" ")

hhimanshu

% http://www.erlang.org/course/exercises.html
% Write functions temp:f2c(F) and temp:c2f(C) which convert between centigrade and Fahrenheit scales. (hint 5(F-32) = 9C)
-module(temp).
-export([c2f/1, f2c/1, convert/1]).

c2f(C) -> (C *9/5) + 32.
f2c(F) -> (F - 32) * 5/9.

convert({From, What}) ->
        case {From, What} of

hhimanshu

-module(mathStuff).
-export([perimeter/1]).

perimeter({circle, Radius})     -> 2 * math:pi() * Radius;
perimeter({square, Side})       -> 4 * Side;
perimeter({triangle, A, B, C})  -> A + B + C.

hhimanshu

-module(recursive).
-export([minimum/1, maximum/1]).

minimum([]) -> io:format("can not find minimum of empty list~n");

minimum([H|T])  ->
        minimum(H, T).

minimum(Min, [H|T]) ->
        case Min < H of

hhimanshu

% http://www.erlang.org/course/exercises.html#conc

-module(process).
-export([loop/0]).

loop() ->
        receive
                {From, Message} ->  io:format("received [~p] from [~p]~n", [Message, From]),
                loop()
        end.

hhimanshu

### Keybase proof

I hereby claim:

  * I am hhimanshu on github.
  * I am harit (https://keybase.io/harit) on keybase.
  * I have a public key whose fingerprint is 04F0 0F7B 4775 E8EF 5B3B  2836 E703 AF72 5E8D EFF3

To claim this, I am signing this object:

hhimanshu

package com.learner.s99

/*
(*) Find the last element of a list.
Example:
scala> last(List(1, 1, 2, 3, 5, 8))
res0: Int = 8
 */

object P01 {

hhimanshu

package com.learner.s99

/**
 * (*) Find the last but one element of a list.
 * Example:
 * scala> penultimate(List(1, 1, 2, 3, 5, 8))
 * res0: Int = 5
 */
object P02 {
  def penultimate(input: List[Any]): Any = penultimate(input, None, None)