jamesob

35c35
< index 0000000000..36188f8471
---
> index 0000000000..c82ecaea8c
38c38
< @@ -0,0 +1,144 @@
---
> @@ -0,0 +1,158 @@
58a59
> +    settings.command_line_options["name"].push_back("val2");

jamesob

To recreate:

git remote add jamesob https://github.com/jamesob/bitcoin.git
git fetch jamesob

# Base branch:
# d5dbb45bdf - Merge #15314: [Doc] update release notes for changes up to cb35f1d (8 weeks ago)
#
git diff d5dbb45bdf jamesob:ackr/15141.1.sdaftuar.rewrite_dos_interface_be > 1.daf23bf-base.diff

jamesob

diff --git a/doc/developer-notes.md b/doc/developer-notes.md
index a6df17ddd..a952eeed7 100644
--- a/doc/developer-notes.md
+++ b/doc/developer-notes.md
@@ -257,6 +257,48 @@ make cov
 # A coverage report will now be accessible at `./test_bitcoin.coverage/index.html`.
 ```
 
+### Performance profiling with perf
+

jamesob

2018-05-asynclog vs. master (absolute)

name	iterations	2018-05-asynclog	master
build.make.5.clang.mem-usage	1	645988.00	612340.0
ibd.local.200000.dbcache=2048	4	197.81	206.9
ibd.local.200000.dbcache=2048.mem-usage	4	864743.00	858984.0
gitclone	1	7.89
build.make.5.clang	1	292.50	296.7

jamesob

master vs. threadnames-rebased (absolute)

name	iterations	master	threadnames-rebased
ibd.local.200000.dbcache=2048.mem-usage	4	861795.00	864879.0
gitclone	1	7.64
ibd.local.200000.dbcache=2048	4	205.79	208.7
build.make.5.clang	1	296.87	298.7
build.make.5.clang.mem-usage	1	611652.00	611932.0

jamesob

--- /proc/self/fd/12    2018-07-12 10:27:34.977243847 -0400
+++ /proc/self/fd/13    2018-07-12 10:27:34.981243902 -0400
@@ -94,7 +94,7 @@
      // Parameters
      //
 diff --git a/src/httpserver.cpp b/src/httpserver.cpp
-index bd08b04..1355071 100644
+index bd08b04..229ff86 100644
 --- a/src/httpserver.cpp
 +++ b/src/httpserver.cpp

jamesob

diff --git a/src/threadutil.cpp b/src/threadutil.cpp
index 0630eff..c558c50 100644
--- a/src/threadutil.cpp
+++ b/src/threadutil.cpp
@@ -50,10 +50,9 @@ std::string thread_util::GetInternalName() {
  * Set the in-memory internal name for this thread. Does not affect the process
  * name.
  */
-static bool SetInternalName(const std::string& name)
+static void SetInternalName(const std::string& name)

jamesob

 [Fri 22 15:51] james/src/bitcoin atmp-p2p-refactor* btc
 $ git show-ref atmp-p2p-refactor

2567ef43f3efd99ed08a5eb841251ed9111732d3 refs/heads/atmp-p2p-refactor
2567ef43f3efd99ed08a5eb841251ed9111732d3 refs/remotes/skeees/atmp-p2p-refactor

 [Fri 22 15:51] james/src/bitcoin atmp-p2p-refactor* btc
 $ git lg | head -n 4

* 2567ef4 - (HEAD -> atmp-p2p-refactor, tag: skeees-atmp-p2p-refactor.1, skeees/atmp-p2p-refactor) [refactor, move-only-ish] Refactor mempool accept/reject logic (2 hours ago)

jamesob

--- /proc/self/fd/15	2018-06-13 15:37:25.517994103 -0400
+++ /proc/self/fd/16	2018-06-13 15:37:25.509994021 -0400
@@ -1,8 +1,8 @@
 diff --git a/configure.ac b/configure.ac
-index af60b28..5306f60 100644
+index af60b28..0f9815e 100644
 --- a/configure.ac
 +++ b/configure.ac
-@@ -759,8 +759,21 @@ AC_LINK_IFELSE([AC_LANG_SOURCE([
+@@ -759,8 +759,23 @@ AC_LINK_IFELSE([AC_LANG_SOURCE([

jamesob

diff --git a/src/threadutil.cpp b/src/threadutil.cpp
index 6ad720c..29bae65 100644
--- a/src/threadutil.cpp
+++ b/src/threadutil.cpp
@@ -12,8 +12,9 @@
 #include <threadutil.h>
 
 /*
- * TODO: using thread_local changes the abi in ways that may not play nice
- * when the c++ stdlib is linked dynamically. Disable it until thorough