When will this function return null?
function CurrentLineHighlightSuspends({
lineNumber,
sourceId
}) {
const client = useContext(ReplayClientContext);
Jason Laster jasonLaster
jasonLaster
/ CurrentLineHighlightSuspsends.md
Last active
December 4, 2022 02:47
jasonLaster
/ foo.diff
Created
October 4, 2022 23:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| diff --git a/packages/e2e-tests/package.json b/packages/e2e-tests/package.json | |
| index df53be109..b000905da 100644 | |
| --- a/packages/e2e-tests/package.json | |
| +++ b/packages/e2e-tests/package.json | |
| @@ -10,6 +10,7 @@ | |
| "test": "playwright test", | |
| "test:chromium": "playwright test --project chromium --reporter=@replayio/playwright/reporter,line", | |
| "test:replay-chromium": "playwright test --project replay-chromium --reporter=@replayio/playwright/reporter,line", | |
| + "test:record": "RECORD=true playwright test --reporter=@replayio/playwright/reporter,line", | |
| "test:debug": "DEBUG=1 playwright test", |
jasonLaster
/ foo.diff
Created
September 21, 2022 16:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| diff --git a/src/devtools/client/debugger/src/components/Editor/LineHitCounts.tsx b/src/devtools/client/debugger/src/components/Editor/LineHitCounts.tsx | |
| index 3af52ff79..05b4d7f6c 100644 | |
| --- a/src/devtools/client/debugger/src/components/Editor/LineHitCounts.tsx | |
| +++ b/src/devtools/client/debugger/src/components/Editor/LineHitCounts.tsx | |
| @@ -137,6 +137,11 @@ function LineHitCounts({ sourceEditor }: Props) { | |
| `-${gutterWidth}` | |
| ); | |
| + (gutterElement as HTMLElement).parentElement!.style.setProperty( | |
| + "--print-statement-button-right-offset" |
jasonLaster
/ gist:41b90a1de236280c9e6aada32ab9f8a3
Created
August 15, 2022 23:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| 21sec Console.findMessages:91 c3fc2a78-b0dc-4453-b3cc-90d724101c83 | |
| 460 Child Tasks | |
| 60ms SendControllerIterableMessage getBasicData | |
| 70ms SendControllerMessage getBookmarkInfoArray | |
| 70ms SendControllerMessage getBookmarkInfoArray | |
| 70ms SendControllerMessage getBookmarkInfoArray | |
| 70ms SendControllerMessage getBookmarkInfoArray | |
| 70ms SendControllerMessage getBookmarkInfoArray | |
| 70ms SendControllerMessage getBookmarkInfoArray | |
| 70ms SendControllerMessage getBookmarkInfoArray |
jasonLaster
/ gist:1c62501977c8b0d74f03cb3326af9ae8
Created
August 15, 2022 21:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| 203sec GatherBasicData 5007ffb1-0994-47e6-9732-be43f0604e49 | |
| 331 Child Tasks | |
| 6sec SaplingCollectRegionBasicData | |
| 5sec SaplingCollectRegionBasicData | |
| 5sec SaplingCollectRegionBasicData | |
| 5sec SaplingCollectRegionBasicData | |
| 3sec SaplingCollectRegionBasicData | |
| 2sec SaplingCollectRegionBasicData | |
| 2sec SaplingCollectRegionBasicData | |
| 2sec SaplingCollectRegionBasicData |
jasonLaster
/ foo.diff
Created
August 4, 2022 21:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| diff --git a/packages/protocol/thread/thread.ts b/packages/protocol/thread/thread.ts | |
| index da1347c2a..f5962bfb1 100644 | |
| --- a/packages/protocol/thread/thread.ts | |
| +++ b/packages/protocol/thread/thread.ts | |
| @@ -1053,293 +1053,6 @@ class _ThreadFront { | |
| column: preferredLocation.column, | |
| }; | |
| } | |
| - | |
| - // Given an RRP MappedLocation array with locations in different sources |
jasonLaster
/ foo.diff
Created
August 4, 2022 21:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| packages/protocol/graphics.ts | 2 + | |
| packages/protocol/thread/thread.ts | 287 ------------------------------------- | |
| src/ui/setup/dynamic/devtools.ts | 17 ++- | |
| src/ui/setup/prefs.ts | 7 +- | |
| 4 files changed, 22 insertions(+), 291 deletions(-) |
jasonLaster
/ foo.diff
Created
July 2, 2022 15:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| diff --git a/src/devtools/client/debugger/src/components/Editor/LineNumberTooltip.tsx b/src/devtools/client/debugger/src/components/Editor/LineNumberTooltip.tsx | |
| index 5ca7d4239..f47130487 100644 | |
| --- a/src/devtools/client/debugger/src/components/Editor/LineNumberTooltip.tsx | |
| +++ b/src/devtools/client/debugger/src/components/Editor/LineNumberTooltip.tsx | |
| @@ -27,8 +27,9 @@ function Wrapper({ | |
| loading?: boolean; | |
| showWarning?: boolean; | |
| }) { | |
| - const { nags } = hooks.useGetUserInfo(); | |
| - const showNag = shouldShowNag(nags, Nag.FIRST_BREAKPOINT_ADD); |
jasonLaster
/ gist:2467ba3ccb272fb32436f70755e3f01f
Created
July 2, 2022 15:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| diff --git a/src/devtools/client/debugger/src/components/Editor/LineNumberTooltip.tsx b/src/devtools/client/debugger/src/components/Editor/LineNumberTooltip.tsx | |
| index 5ca7d4239..f47130487 100644 | |
| --- a/src/devtools/client/debugger/src/components/Editor/LineNumberTooltip.tsx | |
| +++ b/src/devtools/client/debugger/src/components/Editor/LineNumberTooltip.tsx | |
| @@ -27,8 +27,9 @@ function Wrapper({ | |
| loading?: boolean; | |
| showWarning?: boolean; | |
| }) { | |
| - const { nags } = hooks.useGetUserInfo(); | |
| - const showNag = shouldShowNag(nags, Nag.FIRST_BREAKPOINT_ADD); |
jasonLaster
/ foo.diff
Created
June 21, 2022 17:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| diff --git a/accessible/generic/LocalAccessible.h b/accessible/generic/LocalAccessible.h | |
| index 7f0b130c05c9..3b60481a43bc 100644 | |
| --- a/accessible/generic/LocalAccessible.h | |
| +++ b/accessible/generic/LocalAccessible.h | |
| @@ -178,14 +178,14 @@ class LocalAccessible : public nsISupports, public Accessible { | |
| // When recording or replaying, use an ID which will be consistent when | |
| // recording/replaying (pointer values are not consistent), so that IPC | |
| // messages from the parent process can be handled when replaying. | |
| - if (recordreplay::IsRecordingOrReplaying()) { | |
| + if (recordreplay::IsRecordingOrReplaying("UniqueID")) { |