jimarnold

diff --git a/phplib/Recsys/ReactorRecs/Infra/Provider/MMXv2/Dynamic/RecSetParams.php b/phplib/Recsys/ReactorRecs/Infra/Provider/MMXv2/Dynamic/RecSetParams.php
index 2487587c4b2a..0c4080f44d03 100644
--- a/phplib/Recsys/ReactorRecs/Infra/Provider/MMXv2/Dynamic/RecSetParams.php
+++ b/phplib/Recsys/ReactorRecs/Infra/Provider/MMXv2/Dynamic/RecSetParams.php
@@ -21,4 +21,8 @@ public function build(): array {
         }
         return $result;
     }
+
+    public function getFeatureLoggingParams(): array {

jimarnold

diff --git a/phplib/Recsys/ReactorRecs/Infra/Filterable.php b/phplib/Recsys/ReactorRecs/Infra/Filterable.php
index 60e97272572d..c8f1cf0defa2 100644
--- a/phplib/Recsys/ReactorRecs/Infra/Filterable.php
+++ b/phplib/Recsys/ReactorRecs/Infra/Filterable.php
@@ -12,33 +12,6 @@ trait Filterable {
      */
     abstract private static function filtersAndFormatters(): array;
 
-    protected RecsInput $filters_input;
-

jimarnold

diff --git a/phplib/Recsys/ReactorRecs/Infra/Filterable.php b/phplib/Recsys/ReactorRecs/Infra/Filterable.php
index 60e97272572d..c8f1cf0defa2 100644
--- a/phplib/Recsys/ReactorRecs/Infra/Filterable.php
+++ b/phplib/Recsys/ReactorRecs/Infra/Filterable.php
@@ -12,33 +12,6 @@ trait Filterable {
      */
     abstract private static function filtersAndFormatters(): array;
 
-    protected RecsInput $filters_input;
-

jimarnold

diff --git a/phplib/Recsys/ReactorRecs/Infra/Filterable.php b/phplib/Recsys/ReactorRecs/Infra/Filterable.php
index e8c93a9fe60f..09ac54e678c1 100644
--- a/phplib/Recsys/ReactorRecs/Infra/Filterable.php
+++ b/phplib/Recsys/ReactorRecs/Infra/Filterable.php
@@ -12,33 +12,20 @@ trait Filterable {
      */
     abstract private static function filtersAndFormatters(): array;
 
-    private RecsInput $filters_input;
+    private RecsInput $filters;

jimarnold

diff --git a/phplib/CategoryNav/V2/Order/CategoryOrderIndia.php b/phplib/CategoryNav/V2/Order/CategoryOrderIndia.php
index 8b2f576020d1..a6cc46daadfa 100644
--- a/phplib/CategoryNav/V2/Order/CategoryOrderIndia.php
+++ b/phplib/CategoryNav/V2/Order/CategoryOrderIndia.php
@@ -62,18 +62,13 @@ class CategoryOrderIndia {
     // J&A - Bags & Purses
     const JA_HANDBAGS = 10867;
     const LUGGAGE_AND_DUFFEL_BAGS = 10871;
-    
+

jimarnold

#!/usr/bin/env node
require('@babel/register');
require('@babel/polyfill');
const DB = require('../server/db').default;

const USER_REPO_PATH = './user_repositories/koliva';

const Taxonomy = require('../src/data/taxonomy').default,
    Attributes = require('../src/data/attributes').default,
    Values = require('../src/data/values').default,

jimarnold

diff --git a/phplib/Atlas/Recsys/BuyerHub/ApiSpecs/Index.php b/phplib/Atlas/Recsys/BuyerHub/ApiSpecs/Index.php
index 840b5d2b7c76..29e4405f3286 100644
--- a/phplib/Atlas/Recsys/BuyerHub/ApiSpecs/Index.php
+++ b/phplib/Atlas/Recsys/BuyerHub/ApiSpecs/Index.php
@@ -4,13 +4,18 @@
 class Atlas_Recsys_BuyerHub_ApiSpecs_Index implements Neu_Api_Spec_IHash {
     use Neu_Api_Spec_Hash;
     const REF_TAG = 'buyer_hub_ref_tag';
+    /**
+     * @var array

jimarnold

diff --git a/src/main/scala/com/etsy/kb/service/common/model/ott/TaxonomyNode.scala b/src/main/scala/com/etsy/kb/service/common/model/ott/TaxonomyNode.scala
index b31bdb0a..3df413cb 100644
--- a/src/main/scala/com/etsy/kb/service/common/model/ott/TaxonomyNode.scala
+++ b/src/main/scala/com/etsy/kb/service/common/model/ott/TaxonomyNode.scala
@@ -51,9 +51,9 @@ object TaxonomyNode {
     * @return whether or not the node is visible
     */
   def isVisible(node: TaxonomyNode): Boolean = {
-    // Nodes are always visible unless they have a seller_node_visibility field AND
-    // it does not contain the value "VISIBLE". I don't make the rules.

jimarnold

commit e8492c0f5c80762ababf1e80148b23307bc2a2d6
Author: Jim Arnold <[email protected]>
Date:   Wed Dec 15 13:26:05 2021 -0500

    [TI-226] fix for adding a migration with a hand-typed attribute value id

diff --git a/src/views/selection/MigrationSelection.js b/src/views/selection/MigrationSelection.js
index 0b95e8a60..1065e61d3 100644
--- a/src/views/selection/MigrationSelection.js
+++ b/src/views/selection/MigrationSelection.js

jimarnold

diff --git a/src/views/search/SearchForm.js b/src/views/search/SearchForm.js
index 112b5dde9..bbbaf68ad 100644
--- a/src/views/search/SearchForm.js
+++ b/src/views/search/SearchForm.js
@@ -80,7 +80,7 @@ export class SearchForm extends Component {
         : [];
     }
 
-    if (!this.props.includeMigrated && this.props.taxonomy !== null) {
+    if (this.props.pageType === 'taxonomy' && !this.props.includeMigrated && this.props.taxonomy !== null) {