Joseph Bridgwater-Rowe josephbridgwaterrowe

Rails Controller Comparison

This Gist compares two different patterns to writing your controllers. My personal preference is orders_first_controller.rb, please feel free to comment with pros and cons of both patterns.

Notes

For this example we are using locals in both examples since instance variables encourage a leaky controller and views.

Machine comparisons were performed with flog and flay

Keybase proof

I hereby claim:

I am josephbridgwaterrowe on github.
I am freakyjoe (https://keybase.io/freakyjoe) on keybase.
I have a public key whose fingerprint is A6F7 B2FF 058A EFA7 2FA0 11A5 AA45 1268 478B 9CFA

To claim this, I am signing this object:

	function thenMiddleware() {
	return next => action => {
	const { then, type, ...rest } = action;
	if (!then) {
	return next(action);
	}

	next({ ...rest, type });

	if (typeof then === 'string') {

	AllCops:
	Exclude:
	- "vendor/*/"
	- "db/schema.rb"
	UseCache: false
	Style/CollectionMethods:
	Description: Preferred collection methods.
	StyleGuide: https://github.com/bbatsov/ruby-style-guide#map-find-select-reduce-size
	Enabled: true
	PreferredMethods:

	<% html = render partial: 'partial_to_render',
	locals: { my_model: my_model } %>
	$.unblockUI();
	$('.modal').modal('hide');
	$('#my-element').html('<%=j html %>');
	$.jGrowl('<%= t(message) %>', { theme: 'alert-success' });

	# /app/form_objects/my_form_object.rb
	class MyFormEntry < FormEntry
	attribute :reference, String

	validate :unique_reference

	def unique_reference
	errors.add(:reference, "must be unique") if \
	MyObject.find_by(reference: self.reference)
	end

	# /app/models/interface/interface_factory.rb
	module Interface
	class InterfaceFactory
	class << self
	def build(context)
	new(context).build
	end
	end

	def initialize(context)

	pg_dump DB_URL --clean --if-exists --no-owner --no-acl --file /tmp/db.dmp
	psql (DB_URL \| -d DB_NAME) < /tmp/db.dmp

	### BEGIN INIT INFO
	# Provides: promiscuous subscribe
	# Default-Start: 2 3 4 5
	# Default-Stop: 0 1 6
	# Short-Description: Execute the promiscuous subscriber
	# Description: Execute the promiscuous subscriber
	### END INIT INFO
	set -e

	# Feel free to change any of the following variables for your app:

	export JAVA_HOME=`/usr/libexec/java_home -v '1.8'`
	export JAVA_PATH=`which java`
	export JAVACMD=`which java`