This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Keybase proof | |
I hereby claim: | |
* I am kevingessner on github. | |
* I am kevingessner (https://keybase.io/kevingessner) on keybase. | |
* I have a public key ASDvVDzG9JX8GS71KJqEOjbArV_DzfV0jpt8mr25cS334Qo | |
To claim this, I am signing this object: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diff --git a/src/test/java/com/google/devtools/build/lib/rules/java/JavaSkylarkApiTest.java b/src/test/java/com/google/devtools/build/lib/rules/java/JavaSkylarkApiTest.java | |
index 025812d..0e7b2a3 100644 | |
--- a/src/test/java/com/google/devtools/build/lib/rules/java/JavaSkylarkApiTest.java | |
+++ b/src/test/java/com/google/devtools/build/lib/rules/java/JavaSkylarkApiTest.java | |
@@ -130,6 +130,73 @@ public class JavaSkylarkApiTest extends BuildViewTestCase { | |
} | |
@Test | |
+ public void testJavaRuntimeProviderJavaLauncher() throws Exception { | |
+ scratch.file( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#!/bin/bash | |
# Checks if all Java and Scala test files in the repository have corresponding Bazel test targets. If not, prints the names of | |
# the missing ones and exits 1. | |
# | |
# Unlike gradle, Bazel does not automatically discover new test files. This script will help us ensure that we don't | |
# have test files lingering that aren't being executed. | |
set -euo pipefail |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diff --git a/src/main/java/com/google/devtools/build/lib/remote/ByteStreamUploader.java b/src/main/java/com/google/devtools/build/lib/remote/ByteStreamUploader.java | |
index 711cdd199e..713d6886d8 100644 | |
--- a/src/main/java/com/google/devtools/build/lib/remote/ByteStreamUploader.java | |
+++ b/src/main/java/com/google/devtools/build/lib/remote/ByteStreamUploader.java | |
@@ -46,6 +46,7 @@ import io.grpc.Status.Code; | |
import io.grpc.StatusRuntimeException; | |
import io.netty.util.AbstractReferenceCounted; | |
import io.netty.util.ReferenceCounted; | |
+import java.io.FileOutputStream; | |
import java.io.IOException; |
OlderNewer