Kieran Jones kieranjones

In August 2007 a hacker found a way to expose the PHP source code on facebook.com. He retrieved two files and then emailed them to me, and I wrote about the issue:

http://techcrunch.com/2007/08/11/facebook-source-code-leaked/

It became a big deal:

http://www.techmeme.com/070812/p1#a070812p1

The two files are index.php (the homepage) and search.php (the search page)

PHP Style Guide

All rules and guidelines in this document apply to PHP files unless otherwise noted. References to PHP/HTML files can be interpreted as files that primarily contain HTML, but use PHP for templating purposes.

The keywords "MUST", "MUST NOT", "REQUIRED", "SHALL", "SHALL NOT", "SHOULD", "SHOULD NOT", "RECOMMENDED", "MAY", and "OPTIONAL" in this document are to be interpreted as described in RFC 2119.

Most sections are broken up into two parts:

Overview of all rules with a quick example
Each rule called out with examples of do's and don'ts

Bulletproof Git Workflow

start working

git checkout master
git pull
git checkout -b feature/my-work
# edit your files

Bulletproof NPM Workflow

Use the Bulletproof Git Workflow, and before code review:

pre-release package

Publish a pre-release version of the package:

	/*
	Taken and cribbed from blog.datalicious.com/free-download-all-australian-postcodes-geocod

	May contain errors where latitude and longitude are off. Use at own non-validated risk.
	*/

	SET NAMES utf8;
	SET sql_mode = 'NO_AUTO_VALUE_ON_ZERO';

	DROP TABLE IF EXISTS postcodes_geo;

	<?php

	/**
	* [list_searcheable_acf list all the custom fields we want to include in our search query]
	* @return [array] [list of custom fields]
	*/
	function list_searcheable_acf(){
	$list_searcheable_acf = array("title", "sub_title", "excerpt_short", "excerpt_long", "xyz", "myACF");
	return $list_searcheable_acf;
	}

	<?php

	$url = 'http://google.com';

	if ($argc > 1){
	$url = $argv[1];
	}

	$ch=curl_init();
	// user credencial

	// First Register the Tab by hooking into the 'woocommerce_product_data_tabs' filter
	add_filter( 'woocommerce_product_data_tabs', 'add_my_custom_product_data_tab' );
	function add_my_custom_product_data_tab( $product_data_tabs ) {
	$product_data_tabs['my-custom-tab'] = array(
	'label' => __( 'My Custom Tab', 'my_text_domain' ),
	'target' => 'my_custom_product_data',
	);
	return $product_data_tabs;
	}

	function mapValues(obj, fn) {
	return Object.keys(obj).reduce((result, key) => {
	result[key] = fn(obj[key], key);
	return result;
	}, {});
	}

	function pick(obj, fn) {
	return Object.keys(obj).reduce((result, key) => {
	if (fn(obj[key])) {

	/*
	##############################
	########### Search ###########
	##############################

	Included are steps to help make this script easier for other to follow
	All you have to do is add custom ACF post types into Step 1 and custom taxonomies into Step 10
	I also updated this work to include XSS and SQL injection projection
	[list_searcheable_acf list all the custom fields we want to include in our search query]
	@return [array] [list of custom fields]