Lam Chau lamchau

Code Review

A guide for reviewing code and having your code reviewed.

Accept that many programming decisions are opinions. Discuss tradeoffs, which you prefer, and reach a resolution quickly.

	#!/bin/sh

	# prerequisite: sudo su - postgres
	CONFIGURATION_FILE="/etc/postgresql/9.4/main/pg_hba.conf"
	CURRENT_IP=$(last -i \| grep "still logged" \| awk '{ print $3 }')
	IPV4_REGEX="\b(25[0-5]\|2[0-4][0-9]\|[01]?[0-9][0-9]?)\.(25[0-5]\|2[0-4][0-9]\|[01]?[0-9][0-9]?)\.(25[0-5]\|2[0-4][0-9]\|[01]?[0-9][0-9]?)\.(25[0-5]\|2[0-4][0-9]\|[01]?[0-9][0-9]?)\b"

	if [ ! -f "$CONFIGURATION_FILE" ]; then
	echo "File not found: $CONFIGURATION_FILE"
	exit 1

	// do not use result cache, nor line and column tracking

	{ var indentStack = [], indent = ""; }

	start
	= INDENT? lines:( blank / line )*
	{ return lines; }

	line
	= SAMEDENT line:(!EOL c:. { return c; })+ EOL?

	var clickElement = function(element) {
	if (!element) {
	return;
	}
	var event = document.createEvent('HTMLEvents');
	event.initEvent('click', true, true);
	event.eventName = 'click';
	element.dispatchEvent(event);
	};

	// Use Gists to store code you would like to remember later on
	console.log(window); // log the "window" object to the console

	def message(message, tries)
	if tries > 0
	puts message + " Please try again. You have #{tries} tries remaining."
	else
	puts "Game over! :("
	end
	end

	min = 1
	max = 100