Skip to content

Instantly share code, notes, and snippets.

@ljbelenky

ljbelenky/Combination Locks.ipynb

Last active July 13, 2021 23:06
Show Gist options
  • Save ljbelenky/845ceb92207ab3b8b69697538575e2f6 to your computer and use it in GitHub Desktop.
Save ljbelenky/845ceb92207ab3b8b69697538575e2f6 to your computer and use it in GitHub Desktop.
Download ZIP
OOP Exercise: Combination Locks
Display the source blob
Display the rendered blob
Raw
Combination Locks.ipynb
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
@ljbelenky
Copy link
Author

Suggestions for further improvement:

  1. As Skylar suggested, hash the combination to prevent peeking
  2. Ensure the user can only enter the code one digit at a time.
  3. Implement checking to see if the digit entered is allowable (i.e, is a number and within the correct range). Determine how to deal with incorrect input (i.e, raise an error, use a default or coerced value, reject the input without an error, display an error message, etc)
  4. Expand the number of allowable digits from 0-9 to 0-n.
  5. Make it send you a text message if someone successfully opens your lock
  6. Have it send a text message if someone attempts to open the lock X number of times and ask you to enable additional attempts.

@ljbelenky
Copy link
Author

Here's one possible solution:

https://github.com/ljbelenky/combination_lock

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment