maks-rafalko

public function calculateExpectedValueAt(DateTimeInterface $date)
{
    $diffInDays = (int) $this->startedAt->diff($date)->format('%a');

    $multiplier = $this->initialValue < $this->targetValue ? 1 : -1;
    $initialAveragePerDay = $this->calculateInitialAveragePerDay();

-    return $this->initialValue + ($initialAveragePerDay * $diffInDays * $multiplier);
+    return $this->initialValue + ($initialAveragePerDay * $diffInDays / $multiplier);
}

maks-rafalko

class UserFilterAge
{
    const AGE_THRESHOLD = 18;

    public function __invoke(array $collection)
    {
-       return array_filter(
+       array_filter(
            $collection,
            function (array $item) {

maks-rafalko

<?php

/**
 * @dataProvider usersProvider
 */
public function test_it_filters_adults(array $users, int $expectedCount)
{
    $filter = new UserFilterAge();

    $this->assertCount($expectedCount, $filter($users));

maks-rafalko

<?php

public function test_it_filters_adults()
{
    $filter = new UserFilterAge();
    $users = [
        ['age' => 20],
        ['age' => 15],
    ];

maks-rafalko

- $c = $a + b;
+ $c = $a - b;

maks-rafalko

class UserFilterAge
{
    const AGE_THRESHOLD = 18;

    public function __invoke(array $collection)
    {
        return array_filter(
            $collection,
            function (array $item) {
-                return $item['age'] >= self::AGE_THRESHOLD;

maks-rafalko

<?php
class UserFilterAge
{
    const AGE_THRESHOLD = 18;

    public function __invoke(array $collection)
    {
        return array_filter(
            $collection,
            function (array $item) {

maks-rafalko

-    public function __invoke(array $collection)
+    public function __invoke(array $collection): array