- Unit tests: Review unit tests first. Unit tests are a fantastic way to grasp how code is meant to be used by others and to learn what the expected behavior is. Are there any test gaps that should be there?
- Method arguments" Make sure arguments to methods make sense and are validated.
- Null References" (Yah yah, we know. Use F# and this goes away. We get it already.) Null references are a bitch and it’s worth looking out for them specifically.
- Conventions Consistency" Make sure naming, formatting, etc. follow our conventions and are consistent. I like a codebase that’s fairly consistent so you know what to expect.
- Disposables: Make sure disposable things are disposed. Look for usages of resources that should be disposed but are not.
- Security: There is a whole threat and mitigation review process that falls under this bucket.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eval File.read('Gemfile') | |
group :development, :test do | |
gem 'pry' | |
gem 'pry-rails' | |
gem 'pry-doc' | |
gem 'pry-git' | |
end | |
group :development do |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
// User settings for plugin | |
{ | |
"resize_delta_default": 0.5 | |
} | |
// Key bindings | |
{ "keys": ["super+r"], "command": "resize_active_group", "args" : { "direction" : "left" } }, | |
{ "keys": ["super+l"], "command": "resize_active_group", "args" : { "direction" : "right" } }, | |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
{ | |
"caret_style": "wide", | |
"color_scheme": "Packages/RailsCasts Colour Scheme/RailsCastsColorScheme.tmTheme", | |
"default_line_ending": "unix", | |
"detect_indentation": false, | |
"disabled_keymap_actions": "reflect_css_value, match_pair_outward", | |
"ensure_newline_at_eof_on_save": true, | |
"folder_exclude_patterns": | |
[ | |
".git", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
'(cd ~/.rbenv/plugins/ruby-build && git pull)' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[color] | |
ui = auto | |
[alias] | |
co = checkout | |
#ci = commit | |
st = status | |
s = status | |
hist = log --pretty=format:'%h %ad | %s%d [%an]' --graph --date=short | |
#type = cat-file -t |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# put this in your .bash_profile | |
if [ $ITERM_SESSION_ID ]; then | |
export PROMPT_COMMAND='echo -ne "\033];$ITERM_PROFILE - ${PWD##*/}\007"; ':"$PROMPT_COMMAND"; | |
fi | |
# Piece-by-Piece Explanation: | |
# the if condition makes sure we only screw with $PROMPT_COMMAND if we're in an iTerm environment | |
# iTerm happens to give each session a unique $ITERM_SESSION_ID we can use, $ITERM_PROFILE is an option too | |
# the $PROMPT_COMMAND environment variable is executed every time a command is run | |
# see: ss64.com/bash/syntax-prompt.html |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# | |
#!optional | |
#!rest | |
#( | |
#\ | |
#\altmode | |
#\backnext | |
#\backspace | |
#\call | |
#\linefeed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
// Source http://stackoverflow.com/questions/16956254/sublimetext2-auto-complete-wrong-for-ruby-do-block | |
<snippet> | |
<content><![CDATA[ | |
do | |
$1 | |
end | |
]]></content> | |
<tabTrigger>do</tabTrigger> | |
<scope>source.ruby</scope> | |
<description>do..end</description> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
My annual reread book is The School of Niklaus Wirth: The Art of Simplicity | |
Others I love: | |
Compiler Construction, Wirth | |
Effective TCP/IP Programming: 44 Tips to Improve Your Network Programs | |
C Programming Language | |
The Annotated C++ Reference Manual (first and last good book on C++, besides meyers) | |
Structure and Interpretation of Computer Programs | |
The Little Schemer, The Seasoned Schemer, (and probably Reasoned Schemer, but I haven't gotten through that yet). |
OlderNewer