pedrocr

diff --git a/src/bauhaus/bauhaus.c b/src/bauhaus/bauhaus.c
index 3642c0f..0d79347 100644
--- a/src/bauhaus/bauhaus.c
+++ b/src/bauhaus/bauhaus.c
@@ -647,7 +647,7 @@ static gboolean dt_bauhaus_combobox_button_press(GtkWidget *widget, GdkEventButt
 static gboolean dt_bauhaus_combobox_scroll(GtkWidget *widget, GdkEventScroll *event, gpointer user_data);
 // static gboolean
 // dt_bauhaus_button_release(GtkWidget *widget, GdkEventButton *event, gpointer user_data);
-static gboolean dt_bauhaus_draw(GtkWidget *widget, cairo_t *crf, gpointer user_data);
+static gboolean dt_bauhaus_draw(GtkWidget *widget, cairo_t *cr, gpointer user_data);

pedrocr

this is darktable 1.7.0+445~g5e38b6a reporting a segfault:

#0  0x00007f60ec55f800 in ?? () from /usr/lib/x86_64-linux-gnu/libpixman-1.so.0
#1  0x00007f60ec598884 in ?? () from /usr/lib/x86_64-linux-gnu/libpixman-1.so.0
#2  0x00007f60ec54d841 in pixman_image_composite32 () from /usr/lib/x86_64-linux-gnu/libpixman-1.so.0
#3  0x00007f60f2917df4 in ?? () from /usr/lib/x86_64-linux-gnu/libcairo.so.2
#4  0x00007f60f2943a9e in ?? () from /usr/lib/x86_64-linux-gnu/libcairo.so.2
#5  0x00007f60f2944d64 in ?? () from /usr/lib/x86_64-linux-gnu/libcairo.so.2
#6  0x00007f60f294bbce in ?? () from /usr/lib/x86_64-linux-gnu/libcairo.so.2
#7  0x00007f60f294c7d9 in ?? () from /usr/lib/x86_64-linux-gnu/libcairo.so.2

pedrocr

Program received signal SIGSEGV, Segmentation fault.
memset () at ../sysdeps/x86_64/memset.S:78
78	../sysdeps/x86_64/memset.S: No such file or directory.
(gdb) bt
#0  memset () at ../sysdeps/x86_64/memset.S:78
#1  0x00007ffff7a51b27 in memset (__len=<optimized out>, __ch=0, __dest=<optimized out>) at /usr/include/x86_64-linux-gnu/bits/string3.h:84
#2  dt_dev_pixelpipe_process_rec (pipe=pipe@entry=0x7ffffffe9180, dev=dev@entry=0x7ffffffe95a0, output=output@entry=0x7ffffffdf540, cl_mem_output=cl_mem_output@entry=0x7ffffffdf560, 
    out_bpp=out_bpp@entry=0x7ffffffdf520, roi_out=roi_out@entry=0x7ffffffdf5c0, modules=0x0, pieces=0x0, pos=pos@entry=0) at /home/pedrocr/Projects/darktable/src/develop/pixelpipe_hb.c:766
#3  0x00007ffff7a4ff02 in dt_dev_pixelpipe_process_rec (pipe=pipe@entry=0x7ffffffe9180, dev=dev@entry=0x7ffffffe95a0, output=output@entry=0x7ffffffdfa40, 
    cl_mem_output=cl_mem_output@entry=0x7ffffffdfa60, out_bpp=out_bpp@entry=0x7ffffffdfa20, roi_out=roi_out@entry=0x7ffffffdf840, modules=0x6c3f40,

pedrocr

$ valgrind /opt/darktable/bin/darktable-cli RAW_SONY_A100.ARW RAW_SONY_A100.ARW.jpg
==7956== Memcheck, a memory error detector
==7956== Copyright (C) 2002-2013, and GNU GPL'd, by Julian Seward et al.
==7956== Using Valgrind-3.10.0.SVN and LibVEX; rerun with -h for copyright info
==7956== Command: /opt/darktable/bin/darktable-cli RAW_SONY_A100.ARW RAW_SONY_A100.ARW.jpg
==7956== 
output file already exists, it will get renamed
[exiv2] Directory SubImage1 with 6496 entries considered invalid; not read.

==7956== Conditional jump or move depends on uninitialised value(s)

pedrocr

$ valgrind /opt/darktable/bin/darktable-cli RAW_SONY_A100.ARW RAW_SONY_A100.ARW.jpg
==11141== Memcheck, a memory error detector
==11141== Copyright (C) 2002-2013, and GNU GPL'd, by Julian Seward et al.
==11141== Using Valgrind-3.10.0.SVN and LibVEX; rerun with -h for copyright info
==11141== Command: /opt/darktable/bin/darktable-cli RAW_SONY_A100.ARW RAW_SONY_A100.ARW.jpg
==11141== 
output file already exists, it will get renamed
[exiv2] Directory SubImage1 with 6496 entries considered invalid; not read.

==11141== Conditional jump or move depends on uninitialised value(s)

pedrocr

$ valgrind /opt/darktable/bin/darktable-cli YDSCF8313.RAF YDSCF8313.RAF.jpg
==12519== Memcheck, a memory error detector
==12519== Copyright (C) 2002-2013, and GNU GPL'd, by Julian Seward et al.
==12519== Using Valgrind-3.10.0.SVN and LibVEX; rerun with -h for copyright info
==12519== Command: /opt/darktable/bin/darktable-cli YDSCF8313.RAF YDSCF8313.RAF.jpg
==12519== 
output file already exists, it will get renamed
==12519== Conditional jump or move depends on uninitialised value(s)
==12519==    at 0x1E388CEB: commit_params (denoiseprofile.c:1528)
==12519==    by 0x4F17752: dt_iop_init_pipe (imageop.c:455)

pedrocr

/*
   dcraw.c -- Dave Coffin's raw photo decoder
   Copyright 1997-2014 by Dave Coffin, dcoffin a cybercom o net

   This is a command-line ANSI C program to convert raw photos from
   any digital camera on any computer running any operating system.

   No license is required to download and use dcraw.c.  However,
   to lawfully redistribute dcraw, you must either (a) offer, at
   no extra charge, full source code* for all executable files

pedrocr

this is darktable 1.7.0+616~ga1c6608 reporting a segfault:

#0  __lll_lock_wait () at ../nptl/sysdeps/unix/sysv/linux/x86_64/lowlevellock.S:135
#1  0x00007fd95657968d in _L_lock_1082 () from /lib/x86_64-linux-gnu/libpthread.so.0
#2  0x00007fd956579607 in __GI___pthread_mutex_lock (mutex=0x1c69810) at ../nptl/pthread_mutex_lock.c:134
#3  0x00007fd953fe9981 in g_mutex_lock () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
#4  0x00007fd95583ecb2 in ?? () from /usr/lib/x86_64-linux-gnu/libgdk-3.so.0
#5  0x00007fd953fa768d in g_main_context_prepare () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
#6  0x00007fd953fa7f03 in ?? () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
#7  0x00007fd953fa830a in g_main_loop_run () from /lib/x86_64-linux-gnu/libglib-2.0.so.0

pedrocr

Reading symbols from /opt/darktable/bin/darktable-cli...done.
(gdb) run
Starting program: /opt/darktable/bin/darktable-cli Panasonic_LX100_aspect_ratio_1to1.RW2 Panasonic_LX100_aspect_ratio_1to1.jpg
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1".
[New Thread 0x7fffe822a700 (LWP 20284)]
[New Thread 0x7fffe7a29700 (LWP 20285)]
[New Thread 0x7fffcdb0c700 (LWP 20286)]
[New Thread 0x7fffcd30b700 (LWP 20287)]
[New Thread 0x7fffccb0a700 (LWP 20288)]

pedrocr

diff -ur RawSpeed/CiffTag.h ../darktable/src/external/rawspeed/RawSpeed/CiffTag.h
--- RawSpeed/CiffTag.h	2015-02-28 13:43:08.905570721 +0000
+++ ../darktable/src/external/rawspeed/RawSpeed/CiffTag.h	2015-02-22 18:08:24.751081341 +0000
@@ -29,6 +29,8 @@
 typedef enum {
   CIFF_NULL         = 0x0000,
   CIFF_MAKEMODEL    = 0x080a,
+  CIFF_SHOTINFO     = 0x102a,
+  CIFF_WHITEBALANCE = 0x10a9,
   CIFF_SENSORINFO   = 0x1031,