Skip to content

Instantly share code, notes, and snippets.

View pomle's full-sized avatar

Pontus Alexander pomle

View GitHub Profile
FAIL src/store/session/__tests__/session.test.js
Session state
reducer
✓ produces an initial state (1ms)
when auth set
✕ stores token (1ms)
✕ stores expiry date (1ms)
✕ stores refresh token
when token set
✓ stores token in state (1ms)
➜ parcel git:(path) while true; do yarn test -- --grep 'should support bundling HTML'; done
yarn run v1.3.2
warning From Yarn 1.0 onwards, scripts don't require "--" for options to be forwarded. In a future version, any explicit "--" will be forwarded as-is to the scripts.
$ cross-env NODE_ENV=test mocha --grep 'should support bundling HTML'
html
1) should support bundling HTML
@pomle
pomle / test.md
Last active November 15, 2017 15:58
mvn flyway:migrate \
    -Dflyway.url=$DATABASE_URL \
    -Dflyway.user=**DATABASE_USER** \
    -Dflyway.password=**DATABASE_PASSWORD**

Useful comments

  • Identification of any functional issues. However, most of the review comments are unrelated to any types of functional defects.

  • Pointing out missing validation checks or alternate scenarios (including corner cases) where the current implementation may fail.

  • Suggestions regarding APIs to use, designs to follow, coding patterns, team coding conventions or best practices.

Somewhat Useful comments

  • “nit-picking issues” (e.g., indentation, comments, style, identifier naming, and typos). Resolution of nit-picking issues helps long-term project maintenance.
import React from 'react';
class MyComponent extends React.Component {
constructor() {
super();
this.handleMouseMove = scrollMiddleWare()(scroll => {
this.setState({
movement: scroll.abs.x,
});
<!DOCTYPE html>
<html>
<head>
<script src="p5.js"></script>
<script type="module">
function setup() {
console.log('setup');
}
function draw() {
move 6 has score -32768
move 5 has score -32768
move 3 has score -32768
move 2 has score -32768
move 1 has score -2
move 0 has score -32768
AlphaBetaPlayer at depth 10 (player 1) eval: -2
GameHandler: Player 1 played 1.
. . . . X . .
. . O X O . .
function fail() {
return new Promise((resolve, reject) => {
reject(new Error('This failed'));
});
}
function doAction() {
return fail()
.catch(error => {
console.log('Arbitrarily chosen error logging the caller can not know about.');