pritidesai

apiVersion: tekton.dev/v1beta1
kind: PipelineRun
metadata:
  name: when-expression-params-with-finally
spec:
  pipelineSpec:
    params:
      - name: MESSAGE
        default: "HI"
    tasks:

pritidesai

  kubectl get pr when-expression-9 -o json
  {
    "apiVersion": "tekton.dev/v1beta1",
    "kind": "PipelineRun",
    "metadata": {
      "annotations": {
        "kubectl.kubernetes.io/last-applied-configuration": "{\"apiVersion\":\"tekton.dev/v1beta1\",\"kind\":\"PipelineRun\",\"metadata\":{\"annotations\":{},\"name\":\"when-expression-9\",\"namespace\":\"default\"},\"spec\":{\"pipelineSpec\":{\"finally\":[{\"name\":\"echo-message-3\",\"taskSpec\":{\"steps\":[{\"image\":\"ubuntu\",\"name\":\"echo\",\"script\":\"#!/usr/bin/env bash\\necho \\\"Hi!\\\"\\n\"}]}}],\"tasks\":[{\"name\":\"echo-message-1\",\"taskSpec\":{\"results\":[{\"description\":\"The sum of the two provided integers\",\"name\":\"message\"}],\"steps\":[{\"image\":\"ubuntu\",\"name\":\"echo\",\"script\":\"#!/usr/bin/env bash\\necho -n \\\"HI\\\" | tee $(results.message.path)\\n\"}]}},{\"name\":\"echo-message-2\",\"taskSpec\":{\"steps\":[{\"image\":\"ubuntu\",\"name\":\"echo\",\"script\":\"#!/usr/bin/env bash\\necho \\\"Hi!\\\"\\n\"}]},\"when\":[

pritidesai

 kubectl get pr -o json
{
    "apiVersion": "v1",
    "items": [
        {
            "apiVersion": "tekton.dev/v1beta1",
            "kind": "PipelineRun",
            "metadata": {
                "annotations": {
                    "kubectl.kubernetes.io/last-applied-configuration": "{\"apiVersion\":\"tekton.dev/v1beta1\",\"kind\":\"PipelineRun\",\"metadata\":{\"annotations\":{},\"name\":\"pipelinerun-to-skip-task\",\"namespace\":\"default\"},\"spec\":{\"params\":[{\"name\":\"param\",\"value\":\"spec\"}],\"pipelineSpec\":{\"params\":[{\"default\":\"pipelineSpec\",\"name\":\"param\"}],\"tasks\":[{\"name\":\"skip-this-task\",\"taskSpec\":{\"steps\":[{\"image\":\"ubuntu\",\"name\":\"echo\",\"script\":\"#!/usr/bin/env bash\\necho \\\"Good Morning!\\\"\\n\"}]},\"when\":[{\"input\":\"$(params.param)\",\"operator\":\"in\",\"values\":[\"foo\"]}]},{\"name\":\"execute-this-task\",\"runAfter\":[\"skip-this-task\"],\"taskSpec\":{\"steps\":[{\"image\":\"ubuntu\",\"name\":\"echo\",\"script\":\"#!/usr/bin/env bash\\nec

pritidesai

 kubectl get tr -o json
{
    "apiVersion": "v1",
    "items": [
        {
            "apiVersion": "tekton.dev/v1beta1",
            "kind": "TaskRun",
            "metadata": {
                "annotations": {
                    "kubectl.kubernetes.io/last-applied-configuration": "{\"apiVersion\":\"tekton.dev/v1beta1\",\"kind\":\"PipelineRun\",\"metadata\":{\"annotations\":{},\"name\":\"pipelinerun-with-timeout\",\"namespace\":\"default\"},\"spec\":{\"pipelineSpec\":{\"tasks\":[{\"name\":\"echo-good-morning\",\"taskSpec\":{\"steps\":[{\"image\":\"ubuntu\",\"name\":\"echo\",\"script\":\"#!/usr/bin/env bash\\necho \\\"Good Morning!\\\"\\nsleep 60\\n\"}]},\"timeout\":\"0h0m30s\"}]},\"timeout\":\"0h0m3s\"}}\n",

pritidesai

apiVersion: tekton.dev/v1beta1
kind: TaskRun
metadata:
  name: taskrun-failure
spec:
  taskRef:
    name: does-not-exist

pritidesai

./pkg/pod/pod.go:		s.VolumeMounts = append(s.VolumeMounts, vm)
./pkg/pod/pod.go:		vms := append(s.VolumeMounts, toAdd...)
./pkg/pod/status.go:			trs.Steps = append(trs.Steps, v1beta1.StepState{
./pkg/pod/status.go:			trs.Sidecars = append(trs.Sidecars, v1beta1.SidecarState{
./pkg/artifacts/artifacts_storage.go:				c.Secrets = append(c.Secrets, sp)
./pkg/apis/pipeline/v1beta1/resource_types.go:	ts.Steps = append(steps, ts.Steps...)
./pkg/apis/pipeline/v1beta1/resource_types.go:	ts.Steps = append(ts.Steps, steps...)
./pkg/apis/pipeline/v1beta1/resource_types.go:			ts.Volumes = append(ts.Volumes, volume)
./pkg/apis/pipeline/v1alpha1/resource_types.go:	ts.Steps = append(steps, ts.Steps...)
./pkg/apis/pipeline/v1alpha1/resource_types.go:	ts.Steps = append(ts.Steps, steps...)

pritidesai

./cmd/imagedigestexporter/main.go:		output = append(output, v1beta1.PipelineResourceResult{
./pkg/pod/entrypoint.go:		argsForEntrypoint = append(argsForEntrypoint, extraEntrypointArgs...)
./pkg/pod/entrypoint.go:		argsForEntrypoint = append(argsForEntrypoint, resultArgument(steps, results)...)
./pkg/pod/entrypoint.go:			args = append(cmd[1:], args...)
./pkg/pod/entrypoint.go:		argsForEntrypoint = append(argsForEntrypoint, "-entrypoint", cmd[0], "--")
./pkg/pod/entrypoint.go:		argsForEntrypoint = append(argsForEntrypoint, args...)
./pkg/pod/entrypoint.go:		steps[i].VolumeMounts = append(steps[i].VolumeMounts, toolsMount)
./pkg/pod/entrypoint.go:	steps[0].VolumeMounts = append(steps[0].VolumeMounts, downwardMount)
./pkg/pod/entrypoint.go:		resultNames = append(resultNames, r.Name)
./pkg/pod/pod.go:	volumes = append(volumes, implicitVolumes...)

pritidesai

-> kubectl get pr pipelinerun-with-params -o json
{
    "apiVersion": "tekton.dev/v1beta1",
    "kind": "PipelineRun",
    "metadata": {
        "annotations": {
            "kubectl.kubernetes.io/last-applied-configuration": "{\"apiVersion\":\"tekton.dev/v1beta1\",\"kind\":\"Pipeline\",\"metadata\":{\"annotations\":{},\"name\":\"pipeline-with-params\",\"namespace\":\"default\"},\"spec\":{\"finally\":[{\"name\":\"final-sum-params\",\"params\":[{\"name\":\"a\",\"value\":\"$(params.pl-param-x)\"},{\"name\":\"b\",\"value\":\"$(params.pl-param-y)\"}],\"taskRef\":{\"name\":\"sum-params\"}}],\"params\":[{\"default\":\"1\",\"name\":\"pl-param-x\",\"type\":\"string\"},{\"default\":\"1\",\"name\":\"pl-param-y\",\"type\":\"string\"}],\"tasks\":[{\"name\":\"sum-params\",\"params\":[{\"name\":\"a\",\"value\":\"$(params.pl-param-x)\"},{\"name\":\"b\",\"value\":\"$(params.pl-param-y)\"}],\"taskRef\":{\"name\":\"sum-params\"}}]}}\n"
        },
        "creationTimestamp": "2020-07-06T21:50:42Z",
        "generation": 1,

pritidesai

diff --git a/pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go b/pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go
index 575c9fc3..0887a656 100644
--- a/pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go
+++ b/pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go
@@ -141,6 +141,50 @@ func (t ResolvedPipelineRunTask) IsStarted() bool {
 	return true
 }
 
+func inGraph(n string, d *dag.Graph) bool {
+	if _, ok := d.Nodes[n]; ok {

pritidesai

apiVersion: tekton.dev/v1beta1
kind: PipelineRun
metadata:
  name: pipelinerun-with-pipeline-with-task-to-echo-good-morning
spec:
  metadata:
    labels:
      pr1: value1
  pipelineSpec:
    tasks: