pulkitkumar
/ SelfCodeReviewChecklist.txt
Last active
June 14, 2017 10:09
Self Code Review Checklist. (Mobile)
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| - General | |
| [ ] The code works | |
| [ ] The code is easy to understand | |
| [ ] Follows coding conventions | |
| [ ] Names are simple and if possible short | |
| [ ] Names are spelt correctly | |
| [ ] Names contain units where applicable | |
| [ ] Enums are used instead of int constants where applicable | |
| [ ] There are no usages of 'magic numbers' | |
| [ ] All variables are in the smallest scope possible |
pulkitkumar
/ OTC Detail screen
Created
May 11, 2015 10:35
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| code_review_checklist.txt | |
| - General | |
| [+] The code works | |
| [+] The code is easy to understand | |
| [+] Follows coding conventions | |
| [+] Names are simple and if possible short | |
| [+] Names are spelt correctly | |
| [-] Names contain units where applicable | |
| [+] Enums are used instead of int constants where applicable |
pulkitkumar
/ NewSaltDetail checklist
Created
May 6, 2015 10:29
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| NewSaltDetail | |
| code_review_checklist.txt | |
| - General | |
| [+] The code works | |
| [+] The code is easy to understand | |
| [+] Follows coding conventions | |
| [+] Names are simple and if possible short | |
| [+] Names are spelt correctly | |
| [ ] Names contain units where applicable |
pulkitkumar
/ gist:e9eb1b67e2aa8f514c95
Created
May 6, 2015 10:24
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| code_review_checklist.txt | |
| - General | |
| [+] The code works | |
| [+] The code is easy to understand | |
| [+] Follows coding conventions | |
| [+] Names are simple and if possible short | |
| [+] Names are spelt correctly | |
| [ ] Names contain units where applicable | |
| [ ] Enums are used instead of int constants where applicable |
pulkitkumar
/ MedicineDetailActivity checklist.
Created
March 20, 2015 06:47
MedicinceDetailActivity Self review checklist.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| code_review_checklist.txt | |
| - General | |
| [+] The code works | |
| [+] The code is easy to understand | |
| [+] Follows coding conventions | |
| [+] Names are simple and if possible short | |
| [+] Names are spelt correctly | |
| [ ] Names contain units where applicable | |
| [ ] Enums are used instead of int constants where applicable |
pulkitkumar
/ Login Signup Crash fix
Created
March 11, 2015 12:12
Login Signup Crash Fix ( Removed tabs and saving fragment on s
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| - General | |
| [+] The code works | |
| [-] The code is easy to understand | |
| [+] Follows coding conventions | |
| [+] Names are simple and if possible short | |
| [+] Names are spelt correctly | |
| [ ] Names contain units where applicable | |
| [ ] Enums are used instead of int constants where applicable | |
| [ ] There are no usages of 'magic numbers' | |
| [+] All variables are in the smallest scope possible |
pulkitkumar
/ gist:58abf3da78fec3bcc3da
Created
March 10, 2015 12:03
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| - General | |
| [+] The code works | |
| [-] The code is easy to understand | |
| [+] Follows coding conventions | |
| [+] Names are simple and if possible short | |
| [+] Names are spelt correctly | |
| [ ] Names contain units where applicable | |
| [-] Enums are used instead of int constants where applicable | |
| [+] There are no usages of 'magic numbers' | |
| [+] All variables are in the smallest scope possible |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| - General | |
| [+] The code works | |
| [-] The code is easy to understand | |
| [+] Follows coding conventions | |
| [+] Names are simple and if possible short | |
| [+] Names are spelt correctly | |
| [ ] Names contain units where applicable | |
| [-] Enums are used instead of int constants where applicable | |
| [+] There are no usages of 'magic numbers' | |
| [ ] All variables are in the smallest scope possible |
pulkitkumar
/ Self review checklist sort substitutes pager
Last active
August 29, 2015 14:16
Self Review Checklist Sort substitutes pager
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| code_review_checklist.txt | |
| - General | |
| [+] The code works | |
| [-] The code is easy to understand | |
| [+] Follows coding conventions | |
| [+] Names are simple and if possible short | |
| [+] Names are spelt correctly | |
| [ ] Names contain units where applicable | |
| [+] Enums are used instead of int constants where applicable |
NewerOlder