Skip to content

Instantly share code, notes, and snippets.

View scvsoft-marianovicente's full-sized avatar
💀
SCV contractor

Mariano Vicente scvsoft-marianovicente

💀
SCV contractor
View GitHub Profile
@scvsoft-marianovicente
scvsoft-marianovicente / speed.md
Last active October 23, 2019 01:38
How to speed up PRs Approves.

How to speed up PRs Approves.

Since github exists, They popularize the concept of pull request (Prs) when we ship code. In order to get the benefits of code review we use Prs as a way to review what we deliver.

In this process are involve, at least, 2 humans[1]:

A requester (Who ask for the CR), and a reviewer (Who do the code review).

But sometimes a reviewer can have a lot to review, a requester ask for somethign who requiere significant effort to understand, round trips between parts. So it ends with a lot of human time and effort.

Points Summary Solution Effort
1 Insignificant, change a line, type Obvious, zero uncertainty Simple, could do many of these per day.
2 Minimal change, configuration changes Known, ** almost no ** uncertainty Pretty easy, a code re view for quick check
3 Small, a specific feature, research or collaboration with other teams ** insignificant ** Generally known, little ** uncertainty ** I'm going to need ** to focus **, requires ** code review and tests ** with effort, you need ** a ** concentration session.
5 Feature ** complex **, requires ** very little ** research or collaboration with other teams I have an idea, ** research limited to known ** uncertainty Complexity or amount of work requires ** a couple * * of concentration sessions
8 Feature ** complex or large **, requires ** a little ** research The concept and objectives are ** known **, the solution requires ** a little