seadowg

Null safety

Kotlin adds null safety into into it's type system as a first class concept. The following would not compile:

val maybe: String = null

In Kotlin every type has a corresponding 'optional' type denoted with a ?:

seadowg

Post Mortem: Basic auth issue

What did I see?

• A Slack message form Helene asking me to look at a Github issue that looked like a production bug.

What actually happened?

• A change in our OpenRosa http layer (from Apache HttpClient to OkHttp) had created a change in behaviour where, after successfully authenticating with a server over HTTPS, Collect would always preemptively send credentials using Basic Authentication regardless of the Authentication scheme initially used.
• This problem meant that servers that assumed the Authorization header was a Digest one would break.

seadowg

Pain experienced during MediaPlayer refactor

I recently spent some time refactoring how Collect interacts with the Android MediaPlayer (PR here). This resulted in my having to touch a fair amount of the stack involed in form entry so I thought it would be good to do a write up of the pain I experienced (within the code) with some suggestions around improvement we could make.

Disclaimer: all the "Next steps" are definitely just my own and first opinion so are very open to discussion.

ODKView having a lifecycle but not being a Fragment

When Collect renders a Form it uses an ODKView to represent each question (FormEntryPrompt) or "group" of questions. This view is hosted inside a FormEntryActivity. When the user swipes from left to right the ODKView is removed from the view hierarchy and a new one is made for the new question.

seadowg

public final class Helpers {

    private Helpers() {

    }

    public static String createMockReference(ReferenceManager referenceManager, String referenceURI) throws InvalidReferenceException {
        String localURI = UUID.randomUUID().toString();
        return createMockReference(referenceManager, referenceURI, localURI);
    }

seadowg

package org.odk.collect.android.instrumented;

import android.media.MediaRecorder;

import androidx.test.ext.junit.runners.AndroidJUnit4;

import org.junit.Test;
import org.junit.runner.RunWith;

import java.io.File;

seadowg

import android.app.Activity
import android.content.Context
import androidx.fragment.app.Fragment
import kotlin.reflect.KClass
import kotlin.reflect.KProperty

class ObjectProvider {

    private val providers = mutableMapOf<Class<*>, () -> Any?>()
    private val singletons = mutableMapOf<Class<*>, Any?>()

seadowg

class MyApplication : Application() {
    var dependencies: Dependencies = DefaultDependencies()
}

interface Dependencies {
    val thing: Thing
}

fun Activity.dependencies(): Dependencies {
    return (this.application as MyApplication).dependencies