senny

$ bundle exec ruby -Ilib:test test/generators/app_generator_test.rb

Run options: --seed 43786

# Running tests:

...........................................................

Finished tests in 255.709194s, 0.2307 tests/s, 1.5486 assertions/s.

senny

virtus :: (re_introduce_value_object_with) » bundle exec rake
rake aborted!
Don't know how to build task 'default'

(See full trace by running task with --trace)

senny

43dd92b (HEAD, stable_test_fix) TMP [Yves Senn] [6 hours ago]

diff --git a/activerecord/test/cases/relations_test.rb b/activerecord/test/cases/relations_test.rb
index 9a4a07d..70d3fbf 100644
--- a/activerecord/test/cases/relations_test.rb
+++ b/activerecord/test/cases/relations_test.rb
@@ -634,21 +634,21 @@ class RelationTest < ActiveRecord::TestCase
 
   def test_find_all_using_where_with_relation_with_bound_values
     david = authors(:david)

senny

Git-Workshop Hints

History durchforschen

• Ein Commit komplett anzeigen: git log -1 --format=fuller <commit>
• Commit Messages durchsuchen: git log --grep=<pattern>
• Commit Diffs durchsuchen: git log -S<string>
• Geänderte Dateien der Commits anzeigen: git log --stat
• Diff der Commits anzeigen: git log -p
• Alle Commits zu einem File / Ordner anzeigen: git log

senny

  def test_timestamp_with_zone_values_without_rails_time_zone_support
    p @connection.execute('SHOW TIME ZONE', 'SCHEMA').first["TimeZone"]
    with_timezone_config default: :local, aware_attributes: false do
      @connection.reconnect!
      @connection.execute("SET time zone 'America/Jamaica'", 'SCHEMA')

      @first_timestamp_with_zone = PostgresqlTimestampWithZone.find(1)
      assert_equal Time.utc(2010,1,1, 11,0,0), @first_timestamp_with_zone.time
      assert_instance_of Time, @first_timestamp_with_zone.time
      p @connection.execute('SHOW TIME ZONE', 'SCHEMA').first["TimeZone"]

senny

  1) Failure:
BasicsTest#test_preserving_time_objects_with_time_with_zone_conversion_to_default_timezone_local [/Users/senny/Projects/rails/activerecord/test/cases/base_test.rb:279]:
--- expected
+++ actual
@@ -1 +1 @@
-[0, 0, 1, 1, 1, 2000, 6, 1, false, "EST"]
+[0, 0, 0, 1, 1, 2000, 6, 1, false, "CST"]

senny

diff --git a/activerecord/lib/active_record/log_subscriber.rb b/activerecord/lib/active_record/log_subscriber.rb
index 927fbab..3100638 100644
--- a/activerecord/lib/active_record/log_subscriber.rb
+++ b/activerecord/lib/active_record/log_subscriber.rb
@@ -22,6 +22,7 @@ module ActiveRecord

     def render_bind(column, value)
       if column
+        value = value[:value] if value.is_a?(Hash)
         if column.binary?

senny

require 'active_record'
require 'minitest/autorun'
require 'logger'

# This connection will do for database-independent bug reports.
ActiveRecord::Base.establish_connection(adapter: 'sqlite3', database: ':memory:')
ActiveRecord::Base.logger = Logger.new(STDOUT)

ActiveRecord::Schema.define do
  create_table :event_kinds do |t|

senny

0463698 (HEAD, 4-0-stable) Merge pull request #12646 from severin/polymorphic_belongs_to_touch [Yves Senn] [27 seconds ago]

diff --git a/activerecord/CHANGELOG.md b/activerecord/CHANGELOG.md
index 852be57..adc7003 100644
--- a/activerecord/CHANGELOG.md
+++ b/activerecord/CHANGELOG.md
@@ -1,3 +1,17 @@
+*   Polymorphic belongs_to associations with the `touch: true` option set update the timestamps of
+    the old and new owner correctly when moved between owners of different types.
+