Steve Kingsland skingsland

GENERAL:

You can't include commits from different repos in a single code review using github pull requests, whereas you can with Crucible code reviews.
It's risky to use a pull request for code that isn't ready to be merged yet. What if someone doesn't see the "DON'T MERGE" comment/title, and clicks the big green merge button?

VIEWING:

You can't adjust the line width in which files are displayed, even if you make your browser window wider than the page. Some XML/HTML content extends well past 80 characters.
- There are numerous Chrome extensions which purport to provide this feature, but I haven't been able to get any of them to work for Github:Enterprise.
There is no toggle in the Github UI that lets you ignore white space, so if a change involved indenting a lot of lines, you'll have a hard time figuring out what changed. In Crucible, you can choose to ignore white space.
You can add ?w=1 to any diff URL to ignore whitespace, however. Not sure why Github hides this behind a [secret](h

	<!DOCTYPE html>
	<html xmlns="http://www.w3.org/1999/xhtml" lang="en-US">
	<head>
	<meta http-equiv="Content-Type" content="text/html; charset=utf-8"/>
	</head>
	<body>
	<table>
	<tr>
	<td>
	<table>

	import java.sql.ResultSet;
	import java.sql.SQLException;
	import java.util.Collection;
	import java.util.HashMap;
	import java.util.List;
	import java.util.Map;

	import org.skife.jdbi.v2.StatementContext;
	import org.skife.jdbi.v2.sqlobject.SqlQuery;
	import org.skife.jdbi.v2.sqlobject.customizers.RegisterMapper;

	import java.io.IOException;

	import com.google.common.base.Preconditions;
	import com.google.common.util.concurrent.UncheckedExecutionException;

	import org.apache.commons.io.output.ByteArrayOutputStream;
	import org.jclouds.blobstore.BlobStore;
	import org.jclouds.blobstore.domain.Blob;

	/**