smerritt

* Are there tests? Do the new tests fail if the code is reverted?

* Does it work? There's no such thing as obviously correct, as I've had to learn again and again.

* Check the coverage report; is any new code uncovered? (This might be okay, but take a look.)

* How's the logging?

* Read all the tests; any leftover debugging cruft? Print statements seem particularly common.

smerritt

#!/usr/bin/env python

import benchmark
import Queue
import os
import subprocess
import tempfile
import time
import threading

smerritt

#!/usr/bin/env python

import benchmark
import Queue
import threading
import os


class BenchQueueStuff(benchmark.Benchmark):
    def setUp(self):

smerritt

#!/usr/bin/env python
#
# flake8-checks the staged versions of any changed python files
import os.path
import subprocess
import tempfile
import shutil
import atexit

tempdir = tempfile.mkdtemp()

smerritt

#!/usr/bin/env python
#
# Make some big rings for testing. Doesn't do command-line arg parsing or
# anything fancy; just go change the hard-coded constants. It's not like
# you're going to run this more than a few times before tossing it out.

import os
import subprocess

# clean up from previous runs, if any

smerritt

#!/usr/bin/env python

import sys
import os.path
import subprocess
import tempfile
import re
import json
import shutil
import atexit

smerritt

#!/usr/bin/env python2.7
# -*- coding: utf-8 -*-
#
# Benchmark the relative performance of stdlib's json, simplejson, ujson, and
# a wrapped simplejson that gives the same API as stdlib's json.

import benchmark
import hashlib
import json as stdjson
import simplejson

smerritt

#!/usr/bin/env python2.7
# -*- coding: utf-8 -*-
#
# Benchmark the relative performance of stdlib's json, simplejson, and a
# wrapped simplejson that gives the same API as stdlib's json.

import benchmark
import hashlib
import json as stdjson
import simplejson

smerritt

#!/usr/bin/env python
 # -*- coding: utf-8 -*-
import json
import simplejson

data = {'hello': 'world', u'ok': u'✓',
        'nested': {'array': [1, 2, 3, {'potato': 'potato',
                                       'tomato': 'tomato'}],
                   "that's": 'Numberwäng!'}}

smerritt

diff --git a/swift/obj/auditor.py b/swift/obj/auditor.py
index c672928..4ffb98e 100644
--- a/swift/obj/auditor.py
+++ b/swift/obj/auditor.py
@@ -158,7 +158,8 @@ class AuditorWorker(object):
         :param partition: the partition the path is on
         """
         try:
-            assert isinstance(path, basestring)
+            if not path: