Skip to content

Instantly share code, notes, and snippets.

View sminnee's full-sized avatar

Sam Minnée sminnee

View GitHub Profile
commit 3857cfe2e1d9811d796246a6ec4612cb032c2966
Author: Sam Minnee <[email protected]>
Date: Wed Oct 24 11:45:13 2018 +1300
Fix - remove unnecessary cache
It’s not worth it.
diff --git a/_config/cache.yml b/_config/cache.yml
deleted file mode 100644
diff --git a/src/ORM/Connect/PDOConnector.php b/src/ORM/Connect/PDOConnector.php
index f3fbae1..27ff7b8 100644
--- a/src/ORM/Connect/PDOConnector.php
+++ b/src/ORM/Connect/PDOConnector.php
@@ -356,7 +356,7 @@ class PDOConnector extends DBConnector
// Bind and invoke statement safely
if ($statement) {
$this->bindParameters($statement, $parameters);
- $statement->execute($parameters);
+ $statement->execute();
commit 01b2e3a0f8911c82e5072b2016e525e1ed1ab30a
Author: Sam Minnee <[email protected]>
Date: Fri Sep 21 18:34:47 2018 +1200
FIX: Use Hierarchy::prepopulateTreeDataCache() in fluent
Requires https://github.com/silverstripe/silverstripe-framework/pull/8395
diff --git a/src/Extension/FluentVersionedExtension.php b/src/Extension/FluentVersionedExtension.php
index 5838f10..97c8eba 100644
diff --git a/src/ORM/Connect/Database.php b/src/ORM/Connect/Database.php
index 4c60ed0..e16eba9 100644
--- a/src/ORM/Connect/Database.php
+++ b/src/ORM/Connect/Database.php
@@ -11,6 +11,7 @@ use SilverStripe\ORM\Queries\SQLUpdate;
use SilverStripe\ORM\Queries\SQLInsert;
use BadMethodCallException;
use Exception;
+use SilverStripe\Dev\Backtrace;
@sminnee
sminnee / support-timeframe.md
Created August 30, 2018 22:58
Tracking support timeframes

Tracking support timeframes

Goals

  • Provide a way for the sitesummariser SilverStripe module to query the support timeframes of SilverStripe packages

Stretch goals

  • Get the rest of the SilverStripe ecosystem using this
  • Get the rest of the packagist ecosystem using this
diff --git a/control/Controller.php b/control/Controller.php
index 274b567..484c06f 100644
--- a/control/Controller.php
+++ b/control/Controller.php
@@ -502,7 +502,7 @@ class Controller extends RequestHandler implements TemplateGlobalProvider {
*/
public function redirectBack() {
// Don't cache the redirect back ever
- HTTPCacheControl::singleton()->disableCaching();
+ HTTPCacheControl::singleton()->disableCache(true);
@sminnee
sminnee / suggested-reorg.md
Created May 31, 2018 22:31
release doc reorg

title: Releases and changelogs summary: Upgrading guides, changelogs and support timeframes for each released version of the CWP recipe codebase. introduction: The status of the recipe releases is summarised in the table below. Upgrading information for each version is available in the changelog.

Current Releases

2.0

Supported until further notice, at least 30/11/2019

| Recipe version | Description | Release date |

<?php
namespace Sminnee\LookingStripey\Commands;
use Symfony\Component\Console\Command\Command;
use Symfony\Component\Console\Output\OutputInterface;
use Symfony\Component\Console\Logger\ConsoleLogger;
use Psr\Log\LogLevel;
abstract class BaseCommand extends Command
diff --git a/.platform.yml b/.platform.yml
index 6dd5cb2..fa84e0e 100644
--- a/.platform.yml
+++ b/.platform.yml
@@ -8,3 +8,6 @@ crons:
queuedjobs_task:
time: '* * * * *'
command: 'test -f /var/www/mysite/www/host.txt && /usr/local/bin/sera 1 php /var/www/mysite/www/framework/cli-script.php dev/tasks/ProcessJobQueueTask 2>&1 | logger -t SilverStripe_cron'
+shared_dirs:
+ mysite:
diff --git a/src/Flysystem/AssetAdapter.php b/src/Flysystem/AssetAdapter.php
index 5af0c21..c28fe91 100644
--- a/src/Flysystem/AssetAdapter.php
+++ b/src/Flysystem/AssetAdapter.php
@@ -45,11 +45,9 @@ class AssetAdapter extends Local
private static $file_permissions = array(
'file' => [
'public' => 0644,
- 'private' => 0600,
],