Teimur Gasanov teimurjan

FeatureContext.php

Feature name to seed name map

Extract as Trait or Factory in a separate file.

Translations map

In order to minify errors after changing texts on frontend we should get translations directly from the frontend's en.json, fr.json files. It can be achieved by reading these files from a FeatureContext.php file method like getTranslationWithCode(locale).

Simplify FeatureContext.php

Make FeatureContext.php contains just features methods like "Before", "BeforeStep" etc. So the steps methods like "I click", "I see" should be added as traits. These traits can be separated to groups: Base("I click", "I see"), Group("I publish", "I assign"), Specific("I see something in specific modal")

Do some "Given" steps programmaticaly

Form Edit

Exract EditTab to a container in order to not sending props from the parent.
Make components stateless
Refactor tabs
Extract spinner to a wrapper
Make files/variables names more clear
Extract language to the FornEdit global state

Edit tab

Remove unnecessary handlers
Extract switch to a factory

All builders should be independent and reusable.
No titles should be used for creating foreign key/m-2-m relations, only objects.
Create common functions for creating complex structures(form with page and section, question with option etc.)

Если нет props, то объявлять propTypes не нужно

static propTypes = {};

Вынести в методы класса, иначе будут создаваться новые функции при каждом вызове render

searchField: props => <SearchField {...props} placeholder={this.props.intl('search')}/>
function priceFormatter(cell, row){
  return '<i class="glyphicon glyphicon-usd"></i> ' + cell;
}

	import React, { Component } from "react";
	import logo from "./assets/logo.svg";
	import "./assets/App.css";
	import { SketchField, Tools } from "react-sketch";
	import { makePrediction } from "./api";

	const pixels = count => `${count}px`;
	const percents = count => `${count}px`;

	const MAIN_CONTAINER_WIDTH_PX = 200;

	const validateStatusCode = response =>
	new Promise((resolve, reject) => {
	const status = response.status;
	const next = status < 400 ? resolve : reject;
	response.text().then(next);
	});

	export const makePrediction = image =>
	fetch("/api/predict", {
	method: "POST",

	const ExtractTextPlugin = require("extract-text-webpack-plugin");

	module.exports = {
	module: {
	rules: [
	{
	oneOf: [
	{
	test: /\.css$/,
	loader: ExtractTextPlugin.extract({

	loader: ExtractTextPlugin.extract({
	use: [
	{
	loader: require.resolve("css-loader"),
	options: {
	minimize: true
	}
	}
	]
	});

	const webpack = require("webpack");

	module.exports = {
	plugins: [
	new webpack.DefinePlugin({
	"process.env": {
	NODE_ENV: JSON.stringify("production")
	}
	})
	]