Alex Zhitnitsky tkfx

Product Marketing @ OverOps

tkfx / twitterStyleGuide.java

Created July 5, 2016 10:55

	// Bad.
	// - Line breaks are arbitrary.
	// - Scanning the code makes it difficult to piece the message together.
	throw new IllegalStateException("Failed to process request" + request.getId()
	+ " for user " + user.getId() + " query: '" + query.getText()
	+ "'");

	// Good.
	// - Each component of the message is separate and self-contained.
	// - Adding or removing a component of the message requires minimal reformatting.

tkfx / complexConstructor.java

Created July 5, 2016 13:12

	// simple constructor
	//
	private final int x;
	private final int y;
	private final String z;

	public MyClass(int x, int y, String z) {
	this.x = x;
	this.y = y;
	this.z = z;

tkfx / parentheses.java

Created July 5, 2016 13:14

	if (x == y && a > 10) // bad
	if ((x == y) && (a > 10)) // good

tkfx / logger.java

Created July 5, 2016 15:17

private static final Logger logger = LoggerFactory.getLogger(Class.class);

tkfx / unitName.java

Created July 5, 2016 15:21

	// Bad.
	// - Field names give little insight into what fields are used for.
	class User {
	private final int a;
	private final String m;

	...
	}

	// Good.

tkfx / runSomeAlgorithm.java

Created July 21, 2016 13:09

	private static void runSomeAlgorithm(Graph graph) {
	if (graph == null) {
	return;
	}

	// do something with graph
	}

tkfx / runSomeAlgorithmOptimized.java

Created July 21, 2016 13:10

	private static void runSomeAlgorithm(Graph graph) {

	// do something with graph
	}

tkfx / isOpt1.java

Last active July 21, 2016 15:14

	private static int isOpt(int x, int y) {
	int veryHardCalculation = 0;

	if (x >= y) {
	veryHardCalculation = x * 1000 + y;
	} else {
	veryHardCalculation = y * 1000 + x;
	}
	return veryHardCalculation;
	}

tkfx / isOpt2.java

Last active July 21, 2016 15:14

	private static int isOpt(int x, int y) {
	int veryHardCalculation = 0;

	if (x < y) {
	// this would not require a jump
	veryHardCalculation = y * 1000 + x;
	return veryHardCalculation;
	} else {
	veryHardCalculation = x * 1000 + y;
	return veryHardCalculation;

tkfx / jge.asm

Last active July 21, 2016 15:36