valenting

# HG changeset patch
# User Valentin Gosu <valentin.gosu@gmail.com>
# Parent  a9f76166af0ffd2598d1d0f2fe5a7cd1f64de60f
[mq]: timestamp.patch

MozReview-Commit-ID: J7XgQJ6YRwz

diff --git a/dom/ipc/ContentChild.cpp b/dom/ipc/ContentChild.cpp
--- a/dom/ipc/ContentChild.cpp
+++ b/dom/ipc/ContentChild.cpp

valenting

# 1 "<built-in>"
# 1 "/home/icecold/mozilla-central/config/gcc_hidden.h" 1
/* This Source Code Form is subject to the terms of the Mozilla Public
 * License, v. 2.0. If a copy of the MPL was not distributed with this
 * file, You can obtain one at http://mozilla.org/MPL/2.0/. */

/* Begin all files as hidden visibility */
#pragma GCC visibility push(hidden)
# 1 "<built-in>" 2
# 1 "/home/icecold/mozilla-central/obj-ff-dbg/mozilla-config.h" 1

valenting

# Crash reproducer for clang version 3.8.1-12ubuntu1 (tags/RELEASE_381/final)
# Driver args: "--driver-mode=g++" "-std=gnu++11" "-fPIC" "-Qunused-arguments" "-Qunused-arguments" "-Wall" "-Wc++11-compat" "-Wempty-body" "-Wignored-qualifiers" "-Woverloaded-virtual" "-Wpointer-arith" "-Wsign-compare" "-Wtype-limits" "-Wunreachable-code" "-Wwrite-strings" "-Wno-invalid-offsetof" "-Wclass-varargs" "-Wloop-analysis" "-Wc++11-compat-pedantic" "-Wc++14-compat" "-Wc++14-compat-pedantic" "-Wc++1z-compat" "-Wimplicit-fallthrough" "-Werror=non-literal-null-conversion" "-Wstring-conversion" "-Wthread-safety" "-Wno-inline-new-delete" "-Wno-error=deprecated-declarations" "-Wno-error=array-bounds" "-Wno-unknown-warning-option" "-Wno-return-type-c-linkage" "-fcolor-diagnostics" "-fno-exceptions" "-fno-strict-aliasing" "-fno-rtti" "-fno-exceptions" "-fno-math-errno" "-pthread" "-pipe" "-g" "-fno-omit-frame-pointer" "-Werror" "-pthread" "-Wno-error=shadow" "-fcolor-diagnostics" "-I" "/home/icecold/mozilla-central/obj-ff-dbg/dis

valenting

 ./mach build
 0:00.12 /usr/bin/make -f client.mk MOZ_PARALLEL_BUILD=8 -s
 0:00.69 Adding client.mk options from /home/icecold/mozilla-central/.mozconfig:
 0:00.69     AUTOCLOBBER=1
 0:00.69     MOZ_MAKE_FLAGS=-j8
 0:00.69     MOZ_OBJDIR=/home/icecold/mozilla-central/obj-ff-dbg
 0:00.69     OBJDIR=/home/icecold/mozilla-central/obj-ff-dbg
 0:00.69     FOUND_MOZCONFIG=/home/icecold/mozilla-central/.mozconfig
 0:00.88 Elapsed: 0.00s; From dist/branding: Kept 4 existing; Added/updated 0; Removed 0 files and 0 directories.
 0:00.89 Elapsed: 0.00s; From dist/private: Kept 0 existing; Added/updated 0; Removed 0 files and 0 directories.

valenting

diff --git a/js/script.js b/js/script.js
index 419ea1b..4f83772 100644
--- a/js/script.js
+++ b/js/script.js
@@ -1,4 +1,5 @@
-chrome.extension.sendMessage({}, function(response) {
+let target = chrome.runtime || browser.runtime;
+target.sendMessage({}, function(response) {
     var readyStateCheckInterval = setInterval(function() {
         if (document.readyState === "complete") {

valenting

<!--
  Copyright (c) 2011 Google Inc.

  Licensed under the Apache License, Version 2.0 (the "License"); you may not
  use this file except in compliance with the License. You may obtain a copy of
  the License at

  http://www.apache.org/licenses/LICENSE-2.0

  Unless required by applicable law or agreed to in writing, software

valenting

icecold@icecold-tp:~/workspace/id2210-vt17$ mvn clean compile
[INFO] Scanning for projects...
[INFO]                                                                         
[INFO] ------------------------------------------------------------------------
[INFO] Building Project ID2210 1.0-SNAPSHOT
[INFO] ------------------------------------------------------------------------
Downloading: https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-clean-plugin/2.5/maven-clean-plugin-2.5.pom
Downloaded: https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-clean-plugin/2.5/maven-clean-plugin-2.5.pom (4 KB at 0.8 KB/sec)
Downloading: https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-plugins/22/maven-plugins-22.pom
Downloaded: https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-plugins/22/maven-plugins-22.pom (13 KB at 509.3 KB/sec)

valenting

# HG changeset patch
# User Valentin Gosu <valentin.gosu@gmail.com>
# Parent  ec0e2532c1b00acee8852611a9e4d543ae41c9cb
Bug 1331680 - Add CookieStruct IPDL representation and send a list of CookieStructs to the child in OnStartRequest
* Added CookieStruct to NeckoChannelParams.ipdlh
* Added GetCookieListInternal that appends cookies to a nsTArray<nsCookie*>
* Change GetCookieStringInternal to use GetCookieListInternal
* Add CookieList[] argument to PHttpChannel::OnStartRequest to pass it to the child
* Add nsCookieService::GetCookieStructList to get a list of CookieStructs to send to the child

valenting

valentin: contact devtools. get help for new icon. how they receive info from channel?
extra used bw:
	- probe for how much data each channel is using
	- probe how much _extra_ data channels that race are using
	- track when we have cache entry -> we might use it -> that means we are using extra data
extra probes:
	- async open time + average cache speed = estimation for time to load from cache. implemented once we start cancelling
	- report time gain from racing by comparing onStartRequest time to estimated onStartRequest time (which we estimate by computing cache speed) - if we don't cancel the request we can report OnCacheEntryCheck as the best estimate for time if loaded from cache. (not extra gain, but extra probe for what whould happen if we didn't race)

valenting