Vigneshwaran Raveendran vigneshwaranr

vigneshwaranr / good-future.scala

Created February 14, 2021 06:46

	import scala.concurrent.ExecutionContext.Implicits.global
	import scala.concurrent.Future

	// YESS :(
	someFutureJob().map { value =>
	operate(value)
	}

vigneshwaranr / bad-job-execution.scala

Created February 14, 2021 07:10

	import scala.concurrent.Future

	trait AsyncJob {
	def execute(): Future[Boolean]
	}

	class MyLongRunningJob(asyncJob: AsyncJob) extends Runnable {
	override def run(): Unit = {
	asyncJob.execute()
	}

vigneshwaranr / good-job-execution.scala

Created February 14, 2021 07:14

	import scala.concurrent.duration.Duration
	import scala.concurrent.{Await, Future}

	trait AsyncJob {
	def execute(): Future[Boolean]
	}

	class MyLongRunningJob(asyncJob: AsyncJob) extends Runnable {
	override def run(): Unit = {
	val result = Await.result(asyncJob.execute(), Duration.Inf)

vigneshwaranr / bad-power-plant.scala

Created February 14, 2021 07:36

	import scala.concurrent.Future

	trait WaterSupply {
	def turnOn(): Future[Unit]
	}

	trait PowerPlant {
	def waterSupply: WaterSupply

	def increaseVolumeControl(): Future[Boolean]

vigneshwaranr / good-power-plant.scala

Created February 14, 2021 07:41

	import scala.concurrent.ExecutionContext.Implicits.global
	import scala.concurrent.Future

	trait WaterSupply {
	def turnOn(): Future[Unit]
	}

	trait PowerPlant {
	def waterSupply: WaterSupply

vigneshwaranr / almost-good-api.scala

Last active February 14, 2021 08:14

	import scala.concurrent.ExecutionContext.Implicits.global
	import scala.concurrent.{ExecutionContext, Future}

	trait Request

	trait Response

	trait CacheService {
	def isDuplicateRequest(request: Request)(implicit ec: ExecutionContext): Future[Option[Request]]

vigneshwaranr / good-api.scala

Created February 14, 2021 08:13

	import scala.concurrent.ExecutionContext.Implicits.global
	import scala.concurrent.{ExecutionContext, Future}

	trait Request

	trait Response

	trait CacheService {
	def myOwnEc: ExecutionContext

vigneshwaranr / sneaky-api.scala

Created February 14, 2021 08:34

	def executeOperation(): Future[Boolean] = {
	someHeavyCPUOperation()
	Future(anotherOperation())
	}

vigneshwaranr / bad-lib-code.scala

Created February 14, 2021 08:37

	import scala.concurrent.ExecutionContext.Implicits.global
	import scala.concurrent.{ExecutionContext, Future}

	class API(cacheService: CacheService, processor: Processor) {

	def process(request: Request): Future[Response] = {
	for {
	dedupedRequest <- cacheService.isDuplicateRequest(request)
	response <- processor.process(dedupedRequest)
	_ = cacheService.setCacheForDeduplication(dedupedRequest) // now unplugged from the flow

vigneshwaranr / fix-for-sneaky-library.scala

Created February 14, 2021 08:48

	import scala.concurrent.ExecutionContext.Implicits.global
	import scala.concurrent.{ExecutionContext, Future}

	class API(cacheService: CacheService, processor: Processor) {

	def process(request: Request): Future[Response] = {
	for {
	dedupedRequest <- cacheService.isDuplicateRequest(request)
	response <- processor.process(dedupedRequest)
	_ = cacheService.setCacheForDeduplication(dedupedRequest)