Yu Ishikawa yu-iskw

Conclusion

lintr can't catch the warnings about infix operaters in function paramters. So, we should add the linter about the optional paramters.

Experiment

Test File

I created a file which include the code as follows as R/pkg/inst/tests/dummy_file.R. I had expected that a couple of warnings at dummy(x=x, y=y) were catched.

inst/tests/test_binary_function.R:43:6: style: Put spaces around all infix operators.
  rdd<- map(text.rdd, function(x) {x})
    ~^
inst/tests/test_rdd.R:253:59: style: Place a space before left parenthesis, except in a function call.
  actual <- collect(flatMapValues(intRdd, function(x) { x:(x + 1) }))
                                                          ^
inst/tests/test_rdd.R:296:26: style: Put spaces around all infix operators.
  func <- function(x) { x*x }
                        ~^~

inst/tests/test_binary_function.R:43:6: style: Put spaces around all infix operators.
  rdd<- map(text.rdd, function(x) {x})
    ~^
inst/tests/test_rdd.R:253:59: style: Place a space before left parenthesis, except in a function call.
  actual <- collect(flatMapValues(intRdd, function(x) { x:(x + 1) }))
                                                          ^
inst/tests/test_rdd.R:296:26: style: Put spaces around all infix operators.
  func <- function(x) { x*x }
                        ~^~

inst/tests/test_sparkSQL.R:115:3: style: Closing curly-braces should always be on their own line, unless it's followed by an else.
  }, error = function(err) {
  ^
inst/tests/test_sparkSQL.R:130:1: style: lines should not be more than 100 characters.
  localDF <- data.frame(name=c("John", "Smith", "Sarah"), age=c(19, 23, 18), height=c(164.10, 181.4, 173.7))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
inst/tests/test_sparkSQL.R:605:3: style: Closing curly-braces should always be on their own line, unless it's followed by an else.
  }, error = function(err) {
  ^

inst/tests/test_sparkSQL.R:115:3: style: Closing curly-braces should always be on their own line, unless it's followed by an else.
  }, error = function(err) {
  ^
inst/tests/test_sparkSQL.R:130:1: style: lines should not be more than 100 characters.
  localDF <- data.frame(name=c("John", "Smith", "Sarah"), age=c(19, 23, 18), height=c(164.10, 181.4, 173.7))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
inst/tests/test_sparkSQL.R:605:3: style: Closing curly-braces should always be on their own line, unless it's followed by an else.
  }, error = function(err) {
  ^

[SPARK-9249] local variable assigned but may not be used - ASF JIRA

inst/tests/test_binary_function.R:43:6: style: Put spaces around all infix operators.
  rdd<- map(text.rdd, function(x) {x})
    ~^
inst/tests/test_rdd.R:253:59: style: Place a space before left parenthesis, except in a function call.
  actual <- collect(flatMapValues(intRdd, function(x) { x:(x + 1) }))
                                                          ^
inst/tests/test_rdd.R:296:26: style: Put spaces around all infix operators.

inst/tests/test_binary_function.R:43:6: style: Put spaces around all infix operators.
  rdd<- map(text.rdd, function(x) {x})
    ~^
inst/tests/test_rdd.R:253:59: style: Place a space before left parenthesis, except in a function call.
  actual <- collect(flatMapValues(intRdd, function(x) { x:(x + 1) }))
                                                          ^
inst/tests/test_rdd.R:296:26: style: Put spaces around all infix operators.
  func <- function(x) { x*x }
                        ~^~

{
  "def upper(e: Column): Column": {
    "R": false,
    "params": [
      "Column"
    ],
    "return_type": "Column",
    "name": "upper"
  },

	inst/tests/test_binary_function.R:43:6: style: Put spaces around all infix operators.
	rdd<- map(text.rdd, function(x) {x})
	~^
	inst/tests/test_rdd.R:253:59: style: Place a space before left parenthesis, except in a function call.
	actual <- collect(flatMapValues(intRdd, function(x) { x:(x + 1) }))
	^
	inst/tests/test_rdd.R:296:26: style: Put spaces around all infix operators.
	func <- function(x) { x*x }
	~^~
	inst/tests/test_rdd.R:314:21: style: Put spaces around all infix operators.