Skip to content

Instantly share code, notes, and snippets.

@zpao
zpao / compiled.js
Created February 7, 2015 18:35
PR 3085 Code
function b(a) {
return function() {
return a;
};
}
var c = {b:"a", abbr:"abbr", c:"address", d:"area", a:"article", e:"aside"}, d = {}, e;
for (e in c) {
hasOwnProperty.call(c, e) && (d[e] = b.call(void 0, c[e]));
}
var g = "a abbr address area article aside".split(" ").reduce(function(a, f) {
@zpao
zpao / advanced.js
Last active August 29, 2015 14:16
Why we have keyMirror - Google Closure Compiler examples
function d(c) {
var b = {}, a;
for (a in c) {
c.hasOwnProperty(a) && (b[a] = a);
}
return b;
}
var e = d({a:null, b:null, c:null}), f = d({a:null}), g = function(c) {
var b = {};
c.forEach(function(a) {

React-Core Meeting Notes 2015-03-20

Note: This is the first time we're sharing meeting notes publicly. The primary reason we haven't shared these is because we often mix public discussions with matters that are Facebook specific and should not be public. We're really trying to be more open about our development process and what's happening inside the project so moving forward, we'll be sharing meeting notes. While most of us do work at Facebook, we're committed to this being an open project - for now we'll filter out the private notes from the public notes. Hopefully we can make it possible for these meetings to be open to any who wish to attend.

Attendees:

  • @zpao
  • @sebmarkbage
  • @spicyj
  • @jeffmo
--- react-with-addons.js 2015-05-21 19:10:23.000000000 -0700
+++ build/react-with-addons.js 2015-05-21 19:14:38.000000000 -0700
@@ -522,9 +522,9 @@
* @param {string} className the CSS className
* @return {DOMElement} the element passed in
*/
addClass: function (element, className) {
- 'production' !== "development" ? invariant(!/\s/.test(className), 'CSSCore.addClass takes only a single class name. "%s" contains ' + 'multiple classes.', className) : invariant(!/\s/.test(className));
+ !!/\s/.test(className) ? 'production' !== "development" ? invariant(false, 'CSSCore.addClass takes only a single class name. "%s" contains ' + 'multiple classes.', className) : invariant(false) : undefined;
diff --git a/build_helpers/buildNPMInternals.sh b/build_helpers/buildNPMInternals.sh
index 8ad0e19..f103381 100755
--- a/build_helpers/buildNPMInternals.sh
+++ b/build_helpers/buildNPMInternals.sh
@@ -6,6 +6,24 @@ var glob = require('glob');
var path = require('path');
var fs = require('fs');
var babel = require('babel-core');
+var assign = require('object-assign');
+
diff -U4 lib_/Deferred.js lib/Deferred.js
--- lib_/Deferred.js 2015-07-23 15:50:29.000000000 -0700
+++ lib/Deferred.js 2015-07-23 15:54:02.000000000 -0700
@@ -7,9 +7,9 @@
* of patent rights can be found in the PATENTS file in the same directory.
*
* @providesModule Deferred
* @typechecks
- *
+ * @flow
diff -U4 lib_/Deferred.js lib/Deferred.js
--- lib_/Deferred.js 2015-07-23 15:50:29.000000000 -0700
+++ lib/Deferred.js 2015-07-23 18:08:47.000000000 -0700
@@ -7,9 +7,9 @@
* of patent rights can be found in the PATENTS file in the same directory.
*
* @providesModule Deferred
* @typechecks
- *
+ * @flow
diff --git a/src/isomorphic/modern/class/React.d.ts b/src/isomorphic/modern/class/React.d.ts
index ff31760..25ec14a 100644
--- a/src/isomorphic/modern/class/React.d.ts
+++ b/src/isomorphic/modern/class/React.d.ts
@@ -26,6 +26,7 @@ declare module 'React' {
}
export var PropTypes : any;
export function createElement(tag : any, props ?: any, ...children : any[]) : any
+ export function createFactory(component : any) : any
export function render(element : any, container : any) : any
0 info it worked if it ends with ok
1 verbose cli [ 'node',
1 verbose cli '/Users/poshannessy/.nvm/v0.10.40/bin/npm',
1 verbose cli 'deprecate',
1 verbose cli 'react-tools',
1 verbose cli '' ]
2 info using [email protected]
3 info using [email protected]
4 silly mapToRegistry name react-tools
5 silly mapToRegistry using default registry
diff --git a/AUTHORS b/AUTHORS
index 5f34c87..1727f18 100644
--- a/AUTHORS
+++ b/AUTHORS
@@ -13,7 +13,6 @@ Alex <[email protected]>
Alex Boyd <[email protected]>
Alex Lopatin <[email protected]>
Alex Mykyta <[email protected]>
-Alex Pien <[email protected]>
Alex Smith <[email protected]>