ameba report on anykeyh/clear

ameba

# luigi @ x200 in ~/projects/clear on git:master x [17:27:35] 
$ ./bin/ameba  
Inspecting 97 files.

.....F..............F........FF.............F..F...F.F......FFF..........FF......F....F......F...

src/clear/migration/manager.cr:247:5
UnlessElse: Favour if over unless with else

src/clear/model/reflection/table.cr:42:5
UselessAssign: Useless assignment to variable `req`

src/clear/model/modules/has_validation.cr:18:3
PredicateName: Favour method name 'error?' over 'has_error?'

src/clear/model/collection.cr:124:56
UnusedArgument: Unused argument `h`. If it's necessary, use `_` as an argument name to indicate that it won't be used.

src/clear/expression/expression.cr:151:5
UselessAssign: Useless assignment to variable `node`

src/clear/sql/select_builder.cr:32:5
UselessAssign: Useless assignment to variable `d`

src/clear/sql/query/having.cr:33:33
UnusedArgument: Unused argument `question_mark`. If it's necessary, use `_` as an argument name to indicate that it won't be used.

src/clear/sql/query/where.cr:36:33
UnusedArgument: Unused argument `question_mark`. If it's necessary, use `_` as an argument name to indicate that it won't be used.

src/clear/sql/query/fetch.cr:33:7
UselessAssign: Useless assignment to variable `n`

src/clear/sql/query/cte.cr:12:7
UselessAssign: Useless assignment to variable `o`

src/clear/sql/sql.cr:140:5
RedundantBegin: Redundant `begin` block detected

src/clear/cli/command.cr:24:5
UselessAssign: Useless assignment to variable `string`

src/clear/cli/db.cr:13:35
UnusedArgument: Unused argument `options`. If it's necessary, use `_` as an argument name to indicate that it won't be used.

sample/benchmark/model.cr:17:51
LargeNumbers: Large numbers should be written with underscores: 100_000

sample/benchmark/model.cr:18:72
LargeNumbers: Large numbers should be written with underscores: 100_000

sample/benchmark/model.cr:19:55
LargeNumbers: Large numbers should be written with underscores: 100_000

sample/benchmark/model.cr:20:87
LargeNumbers: Large numbers should be written with underscores: 100_000

sample/benchmark/model.cr:21:91
LargeNumbers: Large numbers should be written with underscores: 100_000

spec/migration/migration_spec.cr:38:43
LargeNumbers: Large numbers should be written with underscores: 12_345

spec/sql/select_spec.cr:145:15
UselessAssign: Useless assignment to variable `r`

spec/sql/select_spec.cr:157:15
UselessAssign: Useless assignment to variable `r`

Finished in 340.9 milliseconds 

97 inspected, 21 failures.