Testing sitebricks

SitebricksReplyAssertion.java

/**
 * @author Adelin Ghanayem [email protected]
 */
public class SitebricksReplyAssertion {

  public static <T> void assertIsRepliedWith(Reply<T> reply, T expected) {
    assertFieldValue("entity", reply, expected);
  }

  public static <T> void assertThatReplyStatusIs(Reply<T> reply, int expected) {
    assertFieldValue("status", reply, expected);
  }


  private static <T> void assertFieldValue(String fieldName, Reply reply, T expected) {
    Field field = null;
    try {
      field = reply.getClass().getDeclaredField(fieldName);
      field.setAccessible(true);
      T actual = (T) field.get(reply);
      assert actual != null;
      assertThat(actual, is(equalTo(expected)));
    } catch (NoSuchFieldException e) {
      e.printStackTrace();
    } catch (IllegalAccessException e) {
      e.printStackTrace();
    }
  }
}

having a finally block that returns field.setAccessible to the prior value is a good idea.

would you explain in more details, what for is the final field ?

Hamcrest could improve the way you read your test. Here is small example that is based on your snippet:

 @Test
  public void requestingSingleServiceIsStoredInTheDatastore() {
    final Datastore datastore = context.mock(Datastore.class);
    final Service service = newService("Service1");
    final List<Service> services = listOf(service);

    context.checking(new Expectations() {{
      oneOf(datastore).save(service);
    }});

    ServiceEndpoint endpoint = new ServiceEndpoint(datastore);

    Reply<?> reply = endpoint.provisionService(newRequest(services));

    assertThat(reply, isOk());
    assertThat(reply, containsValue("SUCCESS"));
  }

This is better I guess.